Issue 20889002: Fix depot_tools tests external dependency

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20889002: Fix depot_tools tests external dependency (Closed)

Created:
7 years, 4 months ago by Isaac (away)

Modified:
7 years, 4 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Fix depot_tools tests external dependency git cl was using system git cl. - replace git cl status with GIT_CL_STATUS var - add tested depot_tools to tip of PATH. R=maruel@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=214021

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -19 lines)			Patch
M	tests/abandon.sh	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/basic.sh	View	1 2 3	3 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/owners.sh	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/patch.sh	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/push-basic.sh	View	1 2 3	4 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/push-from-logs.sh	View	1 2 3	3 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/test-lib.sh	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/upload-stale.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/20889002/9001

7 years, 4 months ago (2013-07-27 02:28:52 UTC) #3

Message was sent while issue was closed.

Change committed as 214021