Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 20888002: Disable colors if not a tty. (Closed)

Created:
7 years, 5 months ago by M-A Ruel
Modified:
7 years, 5 months ago
Reviewers:
Isaac (away)
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Disable colors if not a tty. Otherwise this breaks git cl unit tests. Update references to 'git cl' in git cl smoke tests to $GIT_CL. TBR=ilevy@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=214019

Patch Set 1 #

Patch Set 2 : Update references to 'git cl' in git cl smoke tests to $GIT_CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M git_cl.py View 1 chunk +5 lines, -1 line 0 comments Download
M tests/basic.sh View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/patch.sh View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/push-basic.sh View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/push-from-logs.sh View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
Looks good?
7 years, 5 months ago (2013-07-27 02:02:17 UTC) #1
Isaac (away)
always be lgtming
7 years, 5 months ago (2013-07-27 02:02:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/20888002/1
7 years, 5 months ago (2013-07-27 02:06:34 UTC) #3
commit-bot: I haz the power
Presubmit check for 20888002-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 5 months ago (2013-07-27 02:08:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/20888002/6001
7 years, 5 months ago (2013-07-27 02:15:51 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-27 02:17:30 UTC) #6
Message was sent while issue was closed.
Change committed as 214019

Powered by Google App Engine
This is Rietveld 408576698