Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(50)

Issue 20883003: Drop CachedScript from ScriptExecutionContext. (Closed)

Created:
5 years, 9 months ago by Mike West
Modified:
5 years, 9 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Drop CachedScript from ScriptExecutionContext. The CachedScript* parameters to the various 'onerror' handler methods on ScriptExecutionContext are an artifact of the JSC implementation in WebKit. Blink will implement the sanitization functionality differently, which means we can safely remove the CachedScript references to clean things up a bit. BUG=159566 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155058

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M Source/core/dom/ScriptExecutionContext.h View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/core/dom/ScriptExecutionContext.cpp View 6 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mike West
Hey Jochen, mind taking a quick look at this? -mike
5 years, 9 months ago (2013-07-27 15:56:59 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2013-07-27 18:26:07 UTC) #2
Mike West
On 2013/07/27 18:26:07, jochen wrote: > lgtm Danke dir!
5 years, 9 months ago (2013-07-27 18:54:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/20883003/1
5 years, 9 months ago (2013-07-27 18:55:10 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2013-07-27 22:19:17 UTC) #5
Message was sent while issue was closed.
Change committed as 155058

Powered by Google App Engine
This is Rietveld 408576698