Issue 20883003: Drop CachedScript from ScriptExecutionContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20883003: Drop CachedScript from ScriptExecutionContext. (Closed)

Created:
7 years, 4 months ago by Mike West

Modified:
7 years, 4 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Drop CachedScript from ScriptExecutionContext. The CachedScript* parameters to the various 'onerror' handler methods on ScriptExecutionContext are an artifact of the JSC implementation in WebKit. Blink will implement the sanitization functionality differently, which means we can safely remove the CachedScript references to clean things up a bit. BUG=159566 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155058

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -11 lines)			Patch
	M	Source/core/dom/ScriptExecutionContext.h	View		3 chunks	+3 lines, -4 lines	0 comments	Download
	M	Source/core/dom/ScriptExecutionContext.cpp	View		6 chunks	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mike West

On 2013/07/27 18:26:07, jochen wrote: > lgtm Danke dir!

7 years, 4 months ago (2013-07-27 18:54:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/20883003/1

7 years, 4 months ago (2013-07-27 18:55:10 UTC) #4

Message was sent while issue was closed.

Change committed as 155058

Expand Messages | Collapse Messages