Added support for the content protection profile to AttestationFlow.

Added support for the content protection profile to AttestationFlow.

This change moves all attestation certificate requests to the
new CreateCertRequestByProfile dbus method.

BUG=chromium:260504
TEST=unit, manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217673

[Mattias Nissler (ping if slow), 2013-07-29 09:19:25]

I've flagged some empty string literal usage, which I vaguely remember being
advised to not used in the past (in favor of explicit std::string() invocation).
I can't find good justification right now (no mail thread or style guide
section), avoiding the constant in the object file and the unnecessary
conversion come to mind though.

https://codereview.chromium.org/20873002/diff/1/chrome/browser/chromeos/attes...
File chrome/browser/chromeos/attestation/attestation_policy_observer.cc (right):

https://codereview.chromium.org/20873002/diff/1/chrome/browser/chromeos/attes...
chrome/browser/chromeos/attestation/attestation_policy_observer.cc:192: "", //
Not used.
nit: use std::string()

https://codereview.chromium.org/20873002/diff/1/chrome/browser/extensions/api...
File
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
(right):

https://codereview.chromium.org/20873002/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc:208:
"",  // Not used.
nit: std::string()

https://codereview.chromium.org/20873002/diff/1/chromeos/dbus/cryptohome_clie...
File chromeos/dbus/cryptohome_client.h (right):

https://codereview.chromium.org/20873002/diff/1/chromeos/dbus/cryptohome_clie...
chromeos/dbus/cryptohome_client.h:254: int certificate_profile,
The type is a bit unfortunate, and the comment doesn't explain what values are
valid here. I guess it would make sense to move the enum definition into
third_party/cros_system_api/dbus/service_constants.h?

[dkrahn, 2013-08-08 01:29:29]

https://chromiumcodereview.appspot.com/20873002/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/attestation/attestation_policy_observer.cc (right):

https://chromiumcodereview.appspot.com/20873002/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/attestation/attestation_policy_observer.cc:192: "", //
Not used.
On 2013/07/29 09:19:25, Mattias Nissler wrote:
> nit: use std::string()

Done.

https://chromiumcodereview.appspot.com/20873002/diff/1/chrome/browser/extensi...
File
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
(right):

https://chromiumcodereview.appspot.com/20873002/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc:208:
"",  // Not used.
On 2013/07/29 09:19:25, Mattias Nissler wrote:
> nit: std::string()

Done.

https://chromiumcodereview.appspot.com/20873002/diff/1/chromeos/dbus/cryptoho...
File chromeos/dbus/cryptohome_client.h (right):

https://chromiumcodereview.appspot.com/20873002/diff/1/chromeos/dbus/cryptoho...
chromeos/dbus/cryptohome_client.h:254: int certificate_profile,
On 2013/07/29 09:19:25, Mattias Nissler wrote:
> The type is a bit unfortunate, and the comment doesn't explain what values are
> valid here. I guess it would make sense to move the enum definition into
> third_party/cros_system_api/dbus/service_constants.h?

Finally getting back to this... and I don't know why I did this.  I already have
an enum defined.  It doesn't work well in system_api because that would
introduce a dup symbol in cryptohome but it's better than an int.

[Mattias Nissler (ping if slow), 2013-08-08 13:17:14]

LGTM if the trybots don't disagree :)

[dkrahn, 2013-08-09 00:48:46]

+satorux - OWNER of chromeos dbus stuff
+mpcomplete - OWNER of extension API stuff

[Matt Perry, 2013-08-09 00:50:23]

lgtm

https://chromiumcodereview.appspot.com/20873002/diff/8001/chrome/browser/exte...
File
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
(right):

https://chromiumcodereview.appspot.com/20873002/diff/8001/chrome/browser/exte...
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc:1:
// Copyright (c) 2013 The Chromium Authors. All rights reserved.
Could you add an OWNERS file to this directory and include the people who worked
on the API?

[dkrahn, 2013-08-09 01:08:48]

On 2013/08/09 00:50:23, Matt Perry wrote:
> lgtm
> 
>
https://chromiumcodereview.appspot.com/20873002/diff/8001/chrome/browser/exte...
> File
>
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
> (right):
> 
>
https://chromiumcodereview.appspot.com/20873002/diff/8001/chrome/browser/exte...
>
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc:1:
> // Copyright (c) 2013 The Chromium Authors. All rights reserved.
> Could you add an OWNERS file to this directory and include the people who
worked
> on the API?

Unfortunately those who have worked on this API (including myself) do not have
committer status, afaik.  Mattias, would you be willing to own this, considering
it is enterprise-related?  Or do you have a suggestion?

[Mattias Nissler (ping if slow), 2013-08-09 08:55:50]

On 2013/08/09 01:08:48, Darren Krahn wrote:
> On 2013/08/09 00:50:23, Matt Perry wrote:
> > lgtm
> > 
> >
>
https://chromiumcodereview.appspot.com/20873002/diff/8001/chrome/browser/exte...
> > File
> >
>
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
> > (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/20873002/diff/8001/chrome/browser/exte...
> >
>
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc:1:
> > // Copyright (c) 2013 The Chromium Authors. All rights reserved.
> > Could you add an OWNERS file to this directory and include the people who
> worked
> > on the API?
> 
> Unfortunately those who have worked on this API (including myself) do not have
> committer status, afaik.  Mattias, would you be willing to own this,
considering
> it is enterprise-related?  Or do you have a suggestion?

I'm fine if you put put my name there. How about adding a comment in the OWNERS
file explaining this and still listing yourself in the file to be included in
reviews? That'd add some clarity. I'll pull you in for non-trivial changes
anyways, so I guess it doesn't matter much.

[dkrahn, 2013-08-09 21:32:32]

+stevenjb as chromeos/ owner

https://chromiumcodereview.appspot.com/20873002/diff/8001/chrome/browser/exte...
File
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
(right):

https://chromiumcodereview.appspot.com/20873002/diff/8001/chrome/browser/exte...
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc:1:
// Copyright (c) 2013 The Chromium Authors. All rights reserved.
On 2013/08/09 00:50:23, Matt Perry wrote:
> Could you add an OWNERS file to this directory and include the people who
worked
> on the API?

Done.

[Matt Perry, 2013-08-12 17:55:40]

https://chromiumcodereview.appspot.com/20873002/diff/8001/chrome/browser/exte...
File
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
(right):

https://chromiumcodereview.appspot.com/20873002/diff/8001/chrome/browser/exte...
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc:1:
// Copyright (c) 2013 The Chromium Authors. All rights reserved.
On 2013/08/09 21:32:32, Darren Krahn wrote:
> On 2013/08/09 00:50:23, Matt Perry wrote:
> > Could you add an OWNERS file to this directory and include the people who
> worked
> > on the API?
> 
> Done.

Thanks!

[stevenjb, 2013-08-13 20:38:43]

chromeos/ lgtm

https://chromiumcodereview.appspot.com/20873002/diff/16001/chrome/browser/chr...
File chrome/browser/chromeos/attestation/attestation_policy_observer.cc (right):

https://chromiumcodereview.appspot.com/20873002/diff/16001/chrome/browser/chr...
chrome/browser/chromeos/attestation/attestation_policy_observer.cc:193:
std::string(), // Not used.
2 spaces before //

[dkrahn, 2013-08-14 16:26:04]

https://chromiumcodereview.appspot.com/20873002/diff/16001/chrome/browser/chr...
File chrome/browser/chromeos/attestation/attestation_policy_observer.cc (right):

https://chromiumcodereview.appspot.com/20873002/diff/16001/chrome/browser/chr...
chrome/browser/chromeos/attestation/attestation_policy_observer.cc:193:
std::string(), // Not used.
On 2013/08/13 20:38:43, stevenjb (chromium) wrote:
> 2 spaces before //

Done.

[commit-bot: I haz the power, 2013-08-14 16:29:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dkrahn@google.com/20873002/23001

[commit-bot: I haz the power, 2013-08-14 22:16:03]

Change committed as 217673