Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 20871003: Fix BubbleFrameView title and close button patterns. (Closed)

Created:
7 years, 4 months ago by msw
Modified:
7 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, Raman Kakilate, benquan, tfarina, ahutter, Dane Wallinga, dyu1, Evan Stade, Albert Bodenhamer, alicet1, Ilya Sherman, rouslan+autofillwatch_chromium.org, Dan Beam, Mike Wittman
Visibility:
Public.

Description

Fix BubbleFrameView title and close button patterns. Minor BubbleFrameView tweaks for conformity and support. ( needed to support dialogs that call UpdateWindowTitle ) ( needed to support autofill: http://crrev.com/19388006 ) Remove BubbleFrameView SetTitle and SetShowCloseButton. Implement UpdateWindowTitle and ResetWindowControls instead. (more typical patterns, but needs a ResetWindowControls init) Update DialogDelegate, BubbleDelegateView, and AutofillCreditCardBubble. BUG=166075 TEST=No apparent bubble/dialog title or close button changes. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214637

Patch Set 1 #

Patch Set 2 : Sync and merge; add OVERRIDE mark. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -17 lines) Patch
M chrome/browser/ui/views/autofill/autofill_credit_card_bubble_views.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_credit_card_bubble_views.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/views/bubble/bubble_delegate.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/bubble/bubble_delegate.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M ui/views/bubble/bubble_frame_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/bubble/bubble_frame_view.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M ui/views/window/dialog_delegate.cc View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
msw
Hey Scott, please take a look; thanks!
7 years, 4 months ago (2013-07-29 19:23:42 UTC) #1
sky
LGTM
7 years, 4 months ago (2013-07-29 19:55:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/20871003/1
7 years, 4 months ago (2013-07-29 20:06:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/20871003/1
7 years, 4 months ago (2013-07-30 04:50:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/20871003/1
7 years, 4 months ago (2013-07-30 17:07:07 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-07-30 20:26:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/20871003/38001
7 years, 4 months ago (2013-07-30 22:07:00 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=181722
7 years, 4 months ago (2013-07-31 03:48:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/20871003/38001
7 years, 4 months ago (2013-07-31 05:11:19 UTC) #9
commit-bot: I haz the power
7 years, 4 months ago (2013-07-31 08:22:48 UTC) #10
Message was sent while issue was closed.
Change committed as 214637

Powered by Google App Engine
This is Rietveld 408576698