Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Unified Diff: example/todomvc/web/editable_label.dart

Issue 20863002: Introduce boot.js: this finally makes it possible to load and run Todomvc (Closed) Base URL: git@github.com:dart-lang/web-ui.git@master
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: example/todomvc/web/editable_label.dart
diff --git a/example/todomvc/web/editable_label.dart b/example/todomvc/web/editable_label.dart
index 3d72ed713d03da1e54ed53c8780355e5d2a20eef..9ef308d2de0fa6383695f23e472da5598b11ee3c 100644
--- a/example/todomvc/web/editable_label.dart
+++ b/example/todomvc/web/editable_label.dart
@@ -5,6 +5,7 @@
library editable_label;
import 'dart:html';
+import 'dart:async';
import 'package:observe/observe.dart';
import 'package:polymer/polymer.dart';
@@ -33,13 +34,16 @@ class EditableLabel extends PolymerElement with ObservableMixin {
editing = true;
// This causes _editBox to be inserted.
- deliverChangeRecords();
+ notifyChange(new PropertyChangeRecord(const Symbol('editing')));
Jennifer Messerly 2013/07/27 02:18:44 you shouldn't need this line
Siggi Cherem (dart-lang) 2013/07/30 00:10:29 Done.
+ Observable.dirtyCheck();
// For IE and Firefox: use .focus(), then reset the value to move the
// cursor to the end.
- _editBox.focus();
- _editBox.value = '';
- _editBox.value = value;
+ runAsync(() => runAsync(() {
Jennifer Messerly 2013/07/27 02:18:44 add TODO explaining the issue here?
Siggi Cherem (dart-lang) 2013/07/30 00:10:29 Done.
+ _editBox.focus();
+ _editBox.value = '';
+ _editBox.value = value;
+ }));
}
void update(Event e) {
@@ -55,3 +59,7 @@ class EditableLabel extends PolymerElement with ObservableMixin {
}
}
}
+
+_init() {
+ registerPolymerElement('editable-label', () => new EditableLabel());
+}

Powered by Google App Engine
This is Rietveld 408576698