Makefile - Issue 2086253002: Allow application of external mixins to generated dart protos.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Makefile

Issue 2086253002: Allow application of external mixins to generated dart protos. (Closed) Base URL: https://github.com/dart-lang/dart-protoc-plugin.git@master

Patch Set: Update from code review. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 PLUGIN_SRC = \	1 PLUGIN_SRC = \

2 prepend.dart \	2 prepend.dart \

3 bin/protoc_plugin.dart \	3 bin/protoc_plugin.dart \

4 lib/*.dart \	4 lib/*.dart \

5 lib/src/descriptor.pb.dart \	5 lib/src/descriptor.pb.dart \

6 lib/src/plugin.pb.dart	6 lib/src/plugin.pb.dart

7	7

8 OUTPUT_DIR=out	8 OUTPUT_DIR=out

9 PLUGIN_NAME=protoc-gen-dart	9 PLUGIN_NAME=protoc-gen-dart

10 PLUGIN_PATH=$(OUTPUT_DIR)/$(PLUGIN_NAME)	10 PLUGIN_PATH=$(OUTPUT_DIR)/$(PLUGIN_NAME)

11	11

12 BENCHMARK_PROTOS = $(wildcard benchmark/protos/*.proto)	12 BENCHMARK_PROTOS = $(wildcard benchmark/protos/*.proto)

13	13

14 TEST_PROTO_LIST = \	14 TEST_PROTO_LIST = \

15 google/protobuf/unittest_import \	15 google/protobuf/unittest_import \

16 google/protobuf/unittest_optimize_for \	16 google/protobuf/unittest_optimize_for \

17 google/protobuf/unittest \	17 google/protobuf/unittest \

18 dart_name \	18 dart_name \

19 dart_options \	19 dart_options \

20 descriptor_2_5_opensource \	20 descriptor_2_5_opensource \

21 enum_extension \	21 enum_extension \

22 map_api \	22 map_api \

23 map_api2 \	23 map_api2 \

	24 mixins \

24 multiple_files_test \	25 multiple_files_test \

25 nested_extension \	26 nested_extension \

26 non_nested_extension \	27 non_nested_extension \

27 reserved_names \	28 reserved_names \

28 duplicate_names_import \	29 duplicate_names_import \

29 package1 \	30 package1 \

30 package2 \	31 package2 \

31 package3 \	32 package3 \

32 service \	33 service \

33 service2 \	34 service2 \

(...skipping 43 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
77 -Ibenchmark/protos \	78 -Ibenchmark/protos \

78 --plugin=protoc-gen-dart=$(realpath $(PLUGIN_PATH)) \	79 --plugin=protoc-gen-dart=$(realpath $(PLUGIN_PATH)) \

79 $(BENCHMARK_PROTOS)	80 $(BENCHMARK_PROTOS)

80	81

81 run-tests: protos	82 run-tests: protos

82 pub run test	83 pub run test

83	84

84 clean:	85 clean:

85 rm -rf benchmark/lib/generated	86 rm -rf benchmark/lib/generated

86 rm -rf $(OUTPUT_DIR)	87 rm -rf $(OUTPUT_DIR)

OLD	NEW

« no previous file with comments | « no previous file | lib/file_generator.dart » ('j') | lib/file_generator.dart » ('J')