Merge SubframeLoader::createJavaAppletWidget into HTMLAppletElement::udpateWidget

Merge SubframeLoader::createJavaAppletWidget into HTMLAppletElement::udpateWidget

This is its only callsite and the logic really should be part of HTMLAppletElement.

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155091

[abarth-chromium, 2013-07-27 00:16:28]

lgtm

Thanks for breaking this change up into smaller pieces.

https://codereview.chromium.org/20858002/diff/1/Source/core/html/HTMLAppletEl...
File Source/core/html/HTMLAppletElement.cpp (right):

https://codereview.chromium.org/20858002/diff/1/Source/core/html/HTMLAppletEl...
Source/core/html/HTMLAppletElement.cpp:146: const KURL& baseURL =
document()->baseURL();
"const KURL&"  ->  KURL

There's no way saving the KURL copy constructor is worth the risk of the KURL
exploding.

[Nate Chapin, 2013-07-29 16:24:24]

On 2013/07/27 00:16:28, abarth wrote:
> lgtm
> 
> Thanks for breaking this change up into smaller pieces.
> 
>
https://codereview.chromium.org/20858002/diff/1/Source/core/html/HTMLAppletEl...
> File Source/core/html/HTMLAppletElement.cpp (right):
> 
>
https://codereview.chromium.org/20858002/diff/1/Source/core/html/HTMLAppletEl...
> Source/core/html/HTMLAppletElement.cpp:146: const KURL& baseURL =
> document()->baseURL();
> "const KURL&"  ->  KURL
> 
> There's no way saving the KURL copy constructor is worth the risk of the KURL
> exploding.

Good point, I was thinking for some reason that this wasn't passed to any
non-trivial functions, but it gets sent to FrameLoaderClient.

[commit-bot: I haz the power, 2013-07-29 16:32:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/japhet@chromium.org/20858002/7001

[commit-bot: I haz the power, 2013-07-29 18:04:30]

Change committed as 155091