Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Side by Side Diff: components/webdata/common/web_database_migration_unittest.cc

Issue 2085133003: Add billing address to credit cards. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/files/file_util.h" 7 #include "base/files/file_util.h"
8 #include "base/files/scoped_temp_dir.h" 8 #include "base/files/scoped_temp_dir.h"
9 #include "base/guid.h" 9 #include "base/guid.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 // > .output version_nn.sql 123 // > .output version_nn.sql
124 // > .dump 124 // > .dump
125 void LoadDatabase(const base::FilePath::StringType& file); 125 void LoadDatabase(const base::FilePath::StringType& file);
126 126
127 private: 127 private:
128 base::ScopedTempDir temp_dir_; 128 base::ScopedTempDir temp_dir_;
129 129
130 DISALLOW_COPY_AND_ASSIGN(WebDatabaseMigrationTest); 130 DISALLOW_COPY_AND_ASSIGN(WebDatabaseMigrationTest);
131 }; 131 };
132 132
133 const int WebDatabaseMigrationTest::kCurrentTestedVersionNumber = 65; 133 const int WebDatabaseMigrationTest::kCurrentTestedVersionNumber = 66;
134 134
135 void WebDatabaseMigrationTest::LoadDatabase( 135 void WebDatabaseMigrationTest::LoadDatabase(
136 const base::FilePath::StringType& file) { 136 const base::FilePath::StringType& file) {
137 std::string contents; 137 std::string contents;
138 ASSERT_TRUE(GetWebDatabaseData(base::FilePath(file), &contents)); 138 ASSERT_TRUE(GetWebDatabaseData(base::FilePath(file), &contents));
139 139
140 sql::Connection connection; 140 sql::Connection connection;
141 ASSERT_TRUE(connection.Open(GetDatabasePath())); 141 ASSERT_TRUE(connection.Open(GetDatabasePath()));
142 ASSERT_TRUE(connection.Execute(contents.data())); 142 ASSERT_TRUE(connection.Execute(contents.data()));
143 } 143 }
(...skipping 833 matching lines...) Expand 10 before | Expand all | Expand 10 after
977 EXPECT_TRUE(connection.DoesTableExist("server_address_metadata")); 977 EXPECT_TRUE(connection.DoesTableExist("server_address_metadata"));
978 978
979 sql::Statement read_profiles( 979 sql::Statement read_profiles(
980 connection.GetUniqueStatement( 980 connection.GetUniqueStatement(
981 "SELECT id, postal_code FROM server_addresses")); 981 "SELECT id, postal_code FROM server_addresses"));
982 ASSERT_TRUE(read_profiles.Step()); 982 ASSERT_TRUE(read_profiles.Step());
983 EXPECT_FALSE(read_profiles.ColumnString(0).empty()); 983 EXPECT_FALSE(read_profiles.ColumnString(0).empty());
984 EXPECT_EQ("90210", read_profiles.ColumnString(1)); 984 EXPECT_EQ("90210", read_profiles.ColumnString(1));
985 } 985 }
986 } 986 }
987
988 // Tests addition of credit card billing address.
989 TEST_F(WebDatabaseMigrationTest, MigrateVersion65ToCurrent) {
990 ASSERT_NO_FATAL_FAILURE(LoadDatabase(FILE_PATH_LITERAL("version_65.sql")));
991
992 // Verify pre-conditions.
993 {
994 sql::Connection connection;
995 ASSERT_TRUE(connection.Open(GetDatabasePath()));
996 ASSERT_TRUE(sql::MetaTable::DoesTableExist(&connection));
997
998 sql::MetaTable meta_table;
999 ASSERT_TRUE(meta_table.Init(&connection, 65, 65));
1000
1001 EXPECT_FALSE(connection.DoesColumnExist("credit_cards",
1002 "billing_address_id"));
1003
1004 EXPECT_TRUE(connection.Execute(
1005 "INSERT INTO credit_cards(guid, name_on_card) VALUES ('', 'Alice')"));
1006 }
1007
1008 DoMigration();
1009
1010 // Verify post-conditions.
1011 {
1012 sql::Connection connection;
1013 ASSERT_TRUE(connection.Open(GetDatabasePath()));
1014 ASSERT_TRUE(sql::MetaTable::DoesTableExist(&connection));
1015
1016 // Check version.
1017 EXPECT_EQ(kCurrentTestedVersionNumber, VersionFromConnection(&connection));
1018
1019 EXPECT_TRUE(connection.DoesColumnExist("credit_cards",
1020 "billing_address_id"));
1021
1022 sql::Statement read_credit_cards(connection.GetUniqueStatement(
1023 "SELECT name_on_card, billing_address_id FROM credit_cards"));
1024 ASSERT_TRUE(read_credit_cards.Step());
1025 EXPECT_EQ("Alice", read_credit_cards.ColumnString(0));
1026 EXPECT_TRUE(read_credit_cards.ColumnString(1).empty());
1027 }
1028 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698