Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 20843010: Revive Chewing IME for traditional Chinese Input. (Closed)

Created:
7 years, 4 months ago by Seigo Nonaka
Modified:
7 years, 4 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revive Chewing IME for traditional Chinese Input. We replaced ibus-mozc-chewing with new extension based input method but it is not acceptable for traditional Chinese users. This CL remove new input method and revive ibus-mozc-chewing. This CL only contains minimum changes because this is for M29 merges. BUG=266313 TEST=Manually confirmed that the old input method is working on lumpy. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216037

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -29 lines) Patch
M chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc View 1 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chromeos/ime/input_methods.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Seigo Nonaka
7 years, 4 months ago (2013-08-01 02:55:47 UTC) #1
zhangchi
Hi nona, Since our Zhuyin input method shares the same name as the old one, ...
7 years, 4 months ago (2013-08-01 03:35:54 UTC) #2
Seigo Nonaka
https://codereview.chromium.org/20843010/diff/1/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc File chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc (left): https://codereview.chromium.org/20843010/diff/1/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc#oldcode46 chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:46: // Google Chinese Input (zhuyin) Good catch! Fixed. On ...
7 years, 4 months ago (2013-08-01 17:26:09 UTC) #3
Seigo Nonaka
firendly, ping.
7 years, 4 months ago (2013-08-02 17:18:24 UTC) #4
zhangchi
lgtm
7 years, 4 months ago (2013-08-05 09:15:20 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 4 months ago (2013-08-05 16:24:54 UTC) #6
Seigo Nonaka
Adding zork@ Could you take a look? Thank you.
7 years, 4 months ago (2013-08-05 16:27:27 UTC) #7
Seigo Nonaka
Sorry I added google.com by mistake.
7 years, 4 months ago (2013-08-05 16:27:51 UTC) #8
Seigo Nonaka
friendly ping.
7 years, 4 months ago (2013-08-06 16:39:39 UTC) #9
Zachary Kuznia
lgtm
7 years, 4 months ago (2013-08-06 21:33:56 UTC) #10
Seigo Nonaka
Thank you! submitting...
7 years, 4 months ago (2013-08-06 21:35:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/20843010/7001
7 years, 4 months ago (2013-08-06 21:36:00 UTC) #12
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 23:58:20 UTC) #13
Message was sent while issue was closed.
Change committed as 216037

Powered by Google App Engine
This is Rietveld 408576698