Issue 20843008: WebCrypto: Check that the key can be used for given operation.

Issue 20843008: WebCrypto: Check that the key can be used for given operation. (Closed)

Created:
7 years, 4 months ago by eroman

Modified:
7 years, 4 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

WebCrypto: Check that the key can be used for given operation. * key.usages must allow the operation * key.algorithm must match the specified operation BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155322

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Use implicit boolean #

Patch Set 3 : Rebase onto master #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -20 lines)			Patch
M	LayoutTests/crypto/normalize-algorithm.html	View		4 chunks	+54 lines, -14 lines	0 comments	Download
M	LayoutTests/crypto/normalize-algorithm-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/modules/crypto/SubtleCrypto.cpp	View	1	3 chunks	+50 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

lgtm https://codereview.chromium.org/20843008/diff/5001/Source/modules/crypto/SubtleCrypto.cpp File Source/modules/crypto/SubtleCrypto.cpp (right): https://codereview.chromium.org/20843008/diff/5001/Source/modules/crypto/SubtleCrypto.cpp#newcode84 Source/modules/crypto/SubtleCrypto.cpp:84: if ((key.usages() & toKeyUsage(op)) == 0) (key.usages() & ...

7 years, 4 months ago (2013-08-01 02:01:22 UTC) #2

eroman

https://codereview.chromium.org/20843008/diff/5001/Source/modules/crypto/SubtleCrypto.cpp File Source/modules/crypto/SubtleCrypto.cpp (right): https://codereview.chromium.org/20843008/diff/5001/Source/modules/crypto/SubtleCrypto.cpp#newcode84 Source/modules/crypto/SubtleCrypto.cpp:84: if ((key.usages() & toKeyUsage(op)) == 0) On 2013/08/01 02:01:22, ...

7 years, 4 months ago (2013-08-01 02:57:42 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/20843008/11001

7 years, 4 months ago (2013-08-01 06:45:47 UTC) #4

Message was sent while issue was closed.

Change committed as 155322

Expand Messages | Collapse Messages