Source/core/loader/FrameLoader.cpp - Issue 20822002: 'X-Frame-Options: SAMEORIGIN' should check all ancestor frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FrameLoader.cpp

Issue 20822002: 'X-Frame-Options: SAMEORIGIN' should check all ancestor frames. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: tests. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/loader/FrameLoader.cpp

diff --git a/Source/core/loader/FrameLoader.cpp b/Source/core/loader/FrameLoader.cpp

index e0d7c233287fe647c27529562eea260097c07cf9..55e182df683fa16c13d9a233bf1c00c71624fd62 100644

--- a/Source/core/loader/FrameLoader.cpp

+++ b/Source/core/loader/FrameLoader.cpp

@@ -2054,7 +2054,7 @@ bool FrameLoader::shouldInterruptLoadForXFrameOptions(const String& content, con

for (Frame* frame = m_frame->tree()->parent(); frame; frame = frame->tree()->parent()) {

if (!origin->isSameSchemeHostPort(frame->document()->securityOrigin())) {

UseCounter::count(m_frame->document(), UseCounter::XFrameOptionsSameOriginWithBadAncestorChain);

- break;

+ return true;

}

return false;