Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5686)

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java

Issue 2081153005: [Offline Page] Offline page sharing implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased and test update added Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
index f89ab8c7fa824ea668929657769e2d3bac715616..0615a2fe3bc3c398bc2aceb341ce936860e410c1 100644
--- a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
@@ -178,6 +178,26 @@ public class OfflinePageUtilsTest {
any(OfflinePageBridge.SavePageCallback.class));
}
+ @Test
+ @Feature({"OfflinePagesSharing"})
+ public void testRewriteOfflineFileName() {
+ // Only dots in file name get replaced.
+ assertEquals("cs_chromium_org.mhtml",
+ OfflinePageUtils.rewriteOfflineFileName("cs.chromium.org.mhtml"));
+ // Successive dots should all be replaced.
+ assertEquals("cs_chromium___org_.mhtml",
+ OfflinePageUtils.rewriteOfflineFileName("cs.chromium...org..mhtml"));
+ // White spaces are trimmed.
+ assertEquals("cs_chromium_org.mhtml",
+ OfflinePageUtils.rewriteOfflineFileName(" cs.chromium .org .mhtml"));
+ // Other special characters is not touched
+ String directoryPath = "chrome/src/offline/";
+ assertEquals(directoryPath + "cs_chromium!_org#.mhtml",
+ OfflinePageUtils.rewriteOfflineFileName(directoryPath + "cs.chromium!.org#.mhtml"));
+ // If there is no dot other than file extension, nothing changes.
+ assertEquals("chromium.mhtml", OfflinePageUtils.rewriteOfflineFileName("chromium.mhtml"));
+ }
+
/** A shadow/wrapper of android.os.Environment that allows injecting a test directory. */
@Implements(Environment.class)
public static class WrappedEnvironment {

Powered by Google App Engine
This is Rietveld 408576698