chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java - Issue 2081153005: [Offline Page] Offline page sharing implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java

Issue 2081153005: [Offline Page] Offline page sharing implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased and test update added Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java » ('j') | chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java

index f4dc23871fad8b038d4cdc37cc29e72d024a0c7d..110ce20bf50d2840001ec7ad3a5c2f579ed48566 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java

@@ -45,7 +45,7 @@ public class ShareServiceImpl implements ShareService {

}

};

- ShareHelper.share(false, false, mActivity, title, text, null, null, innerCallback);

+ ShareHelper.share(false, false, mActivity, title, text, null, null, null, innerCallback);

}

@Nullable