Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20806004: Remove Explicit Shapes Enablement in Tests (Closed)

Created:
7 years, 5 months ago by Bear Travis
Modified:
7 years, 4 months ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), eae+blinkwatch, Timothy Loh, dstockwell, dglazkov+blink, darktears, Steve Block, Eric Willigers
Visibility:
Public.

Description

Remove Explicit Shapes Enablement in Tests Shapes are enabled by default when running tests, so the calls to internal settings can be removed. BUG=248304 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156108

Patch Set 1 #

Patch Set 2 : Updated Patch - fixing newline typo #

Patch Set 3 : Enabled by default, no need to call internals #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -276 lines) Patch
M LayoutTests/fast/shapes/parsing/script-tests/parsing-shape-inside.js View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/shapes/parsing/script-tests/parsing-shape-lengths.js View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/shapes/parsing/script-tests/parsing-shape-margin.js View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/shapes/parsing/script-tests/parsing-shape-outside.js View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/shapes/parsing/script-tests/parsing-shape-padding.js View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/shapes/resources/multi-segment-polygon.js View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/shapes/resources/simple-polygon.js View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/shapes/resources/simple-rectangle.js View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-animation.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-bottom-edge.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-box-sizing.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-circle.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-circle-padding.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-coincident-vertices.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-coincident-vertices-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-collinear-vertices.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-collinear-vertices-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-dynamic-nested.html View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-dynamic-nested-expected.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-dynamic-shape.html View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-dynamic-text.html View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-ellipse.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-ellipse-padding.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-empty.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-first-fit-001.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-first-fit-002.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-first-fit-003.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-first-fit-004.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-first-fit-004-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-first-fit-reflex.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-inline-elements.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-multiple-blocks.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-multiple-blocks-vertical.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-overflow.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-partial-fill-001.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-partial-fill-002.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-percentage.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-percentage-auto.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-polygon-layout.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-polygon-padding-001.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-polygon-padding-002.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-polygon-padding-003.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-polygon-rectangle.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-polygon-zoom.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-rectangle-padding.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-rectilinear-polygon-001.html View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-rectilinear-polygon-001-expected.html View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-rectilinear-polygon-002.html View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-rectilinear-polygon-002-expected.html View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-rectilinear-polygon-003.html View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-rectilinear-polygon-003-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-rectilinear-polygon-004.html View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-rectilinear-polygon-004-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-regular-polygon16.html View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-regular-polygon16-expected.html View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-regular-polygon8.html View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-regular-polygon8-expected.html View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-rounded-rectangle-001.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-001.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-001-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-002.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-002-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-003.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-003-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-rounded-rectangle-large-radius.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-rounded-rectangle-large-radius-expected.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-rounded-rectangle-padding.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-shape-logical-top.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout-expected.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-text.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-vertical-text.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-bottom.html View 1 2 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bear Travis
Starting review for another shapes test cleanup patch.
7 years, 4 months ago (2013-08-14 16:31:19 UTC) #1
ojan
lgtm
7 years, 4 months ago (2013-08-14 17:13:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/betravis@adobe.com/20806004/11001
7 years, 4 months ago (2013-08-14 17:14:02 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-14 18:50:15 UTC) #4
Message was sent while issue was closed. 
Change committed as 156108

Powered by Google App Engine
This is Rietveld 408576698