Issue 20804003: Re-land: Ensure that ArrayBuffers actively being used by the Web Audio API cannot be neutered

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20804003: Re-land: Ensure that ArrayBuffers actively being used by the Web Audio API cannot be neutered (Closed)

Created:
7 years, 5 months ago by Chris Rogers

Modified:
7 years, 5 months ago

Reviewers:
Chris Rogers

CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, jeez

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Re-land: Ensure that ArrayBuffers actively being used by the Web Audio API cannot be neutered reland 19019002 which was reviewed by kbr@chromium.org TBR=crogers@google.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155032

Patch Set 1 #

Patch Set 2 : rebase #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -6 lines)			Patch
M	Source/modules/webaudio/AudioBuffer.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/webaudio/AudioBuffer.cpp	View	1	3 chunks	+5 lines, -2 lines	0 comments	Download
M	Source/wtf/ArrayBuffer.cpp	View	1	1 chunk	+15 lines, -2 lines	0 comments	Download
M	Source/wtf/ArrayBufferContents.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/wtf/ArrayBufferContents.cpp	View		2 chunks	+12 lines, -0 lines	0 comments	Download
M	Source/wtf/ArrayBufferView.h	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	Source/wtf/ArrayBufferView.cpp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/crogers@google.com/20804003/3001

7 years, 5 months ago (2013-07-26 20:43:16 UTC) #1

Message was sent while issue was closed.

Change committed as 155032

Expand Messages | Collapse Messages