Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2017)

Unified Diff: chrome/renderer/resources/extensions/web_view.js

Issue 20803004: Mark 'download' permissionrequest stable for <webview>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/web_view_experimental.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/web_view.js
diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js
index 9815ed15eb2be743a00e26c44ee389e6ead41123..52126d45df008521d26c95737d4d621032970560 100644
--- a/chrome/renderer/resources/extensions/web_view.js
+++ b/chrome/renderer/resources/extensions/web_view.js
@@ -539,14 +539,6 @@ WebView.prototype.setupExecuteCodeAPI_ = function() {
};
/**
- * @private
- */
-WebView.prototype.getPermissionTypes_ = function() {
- var PERMISSION_TYPES = ['media', 'geolocation', 'pointerLock'];
- return PERMISSION_TYPES.concat(this.maybeGetExperimentalPermissionTypes_());
-};
-
-/**
* @param {!Object} detail The event details, originated from <object>.
* @private
*/
@@ -560,7 +552,7 @@ WebView.prototype.setupPermissionEvent_ = function() {
console.warn(WARNING_MSG_PERMISSION_DENIED.replace('%1', permission));
};
- var PERMISSION_TYPES = this.getPermissionTypes_();
+ var PERMISSION_TYPES = ['media', 'geolocation', 'pointerLock', 'download'];
var EXPOSED_PERMISSION_EVENT_ATTRIBS = [
'lastUnlockedBySelf',
@@ -649,14 +641,6 @@ WebView.prototype.setupPermissionEvent_ = function() {
* Implemented when the experimental API is available.
* @private
*/
-WebView.prototype.maybeGetExperimentalPermissionTypes_ = function() {
- return [];
-};
-
-/**
- * Implemented when the experimental API is available.
- * @private
- */
WebView.prototype.maybeSetupExperimentalAPI_ = function() {};
exports.WebView = WebView;
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/web_view_experimental.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698