Creates a flag to enable/disable spellchecker.

Creates a flag to enable/disable spellchecker.

Add a flag to remove spell-checking inside form fields on Chrome.
Disable the flag for android -- we cannot interact with the spellchecker,
so it doesn't make sense to have it.

This saves us ~300K memory on startup.

BUG=264837
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214621

[jam, 2013-07-26 23:57:22]

lgtm

[Yaron, 2013-07-29 16:08:06]

lgtm

[commit-bot: I haz the power, 2013-07-29 17:40:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mariakhomenko@chromium.org/20794002/28001

[commit-bot: I haz the power, 2013-07-29 17:41:02]

Failed to apply patch for chrome/browser/chrome_content_browser_client.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/chrome_content_browser_client.cc
  Hunk #1 succeeded at 76 (offset 1 line).
  Hunk #2 FAILED at 222.
  Hunk #3 succeeded at 884 (offset 64 lines).
  1 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/chrome_content_browser_client.cc.rej

Patch:       chrome/browser/chrome_content_browser_client.cc
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc
b/chrome/browser/chrome_content_browser_client.cc
index
a166d59767779d67377a3bb7b2f5929267d1131d..81a7fbb168dc113b241f30a1e72c82d53eb29aa6
100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -75,7 +75,6 @@
 #include
"chrome/browser/search_engines/search_provider_install_state_message_filter.h"
 #include "chrome/browser/speech/chrome_speech_recognition_manager_delegate.h"
 #include "chrome/browser/speech/tts_message_filter.h"
-#include "chrome/browser/spellchecker/spellcheck_message_filter.h"
 #include "chrome/browser/ssl/ssl_add_certificate.h"
 #include "chrome/browser/ssl/ssl_blocking_page.h"
 #include "chrome/browser/ssl/ssl_tab_helper.h"
@@ -223,6 +222,10 @@
 #include "chrome/browser/chrome_browser_main_extra_parts_x11.h"
 #endif
 
+#if defined(ENABLE_SPELLCHECK)
+#include "chrome/browser/spellchecker/spellcheck_message_filter.h"
+#endif
+
 using base::FileDescriptor;
 using content::AccessTokenStore;
 using content::BrowserChildProcessHostIterator;
@@ -821,7 +824,9 @@ void ChromeContentBrowserClient::RenderProcessHostCreated(
 #endif
   host->GetChannel()->AddFilter(
       new SearchProviderInstallStateMessageFilter(id, profile));
+#if defined(ENABLE_SPELLCHECK)
   host->GetChannel()->AddFilter(new SpellCheckMessageFilter(id));
+#endif
 #if defined(OS_MACOSX)
   host->GetChannel()->AddFilter(new SpellCheckMessageFilterMac(id));
 #endif

[commit-bot: I haz the power, 2013-07-29 19:39:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mariakhomenko@chromium.org/20794002/36001

[rpetterson, 2013-07-29 20:33:38]

+rouslan

[please use gerrit instead, 2013-07-29 20:40:53]

On 2013/07/29 20:33:38, rpetterson wrote:
> +rouslan

Thank you, Rachel. I also think that this CL looks good. I suggested on the bug
that Maria can save more memory by excluding third_party/hunspell and
third_party/hunspell_dictionaries on Android, if that's not already excluded.
This can be done in a follow-up CL.

[Maria, 2013-07-29 21:16:33]

On 2013/07/29 20:40:53, Rouslan Solomakhin wrote:
> On 2013/07/29 20:33:38, rpetterson wrote:
> > +rouslan
> 
> Thank you, Rachel. I also think that this CL looks good. I suggested on the
bug
> that Maria can save more memory by excluding third_party/hunspell and
> third_party/hunspell_dictionaries on Android, if that's not already excluded.
> This can be done in a follow-up CL.

Thanks for the suggestion! I took a quick look and I think it makes sense to do
that in a follow-up CL, which I'll do.

[commit-bot: I haz the power, 2013-07-30 21:00:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mariakhomenko@chromium.org/20794002/54001

[commit-bot: I haz the power, 2013-07-31 07:48:57]

Change committed as 214621