media/mojo/services/media_mojo_unittest.cc - Issue 2075303002: [DO NOT COMMIT] Initial MediaPlayerRenderer plumbing and basic features

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mojo/services/media_mojo_unittest.cc

Issue 2075303002: [DO NOT COMMIT] Initial MediaPlayerRenderer plumbing and basic features (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/mojo/interfaces/renderer.mojom ('K') | « media/mojo/services/BUILD.gn ('k') | media/mojo/services/mojo_media_player_renderer_helper.h » ('j') | media/mojo/services/mojo_renderer_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/mojo/services/media_mojo_unittest.cc

diff --git a/media/mojo/services/media_mojo_unittest.cc b/media/mojo/services/media_mojo_unittest.cc

index 2c6c9c04c83b76a96ac74631939d68a205f68c7a..411c7aa0e57bd3c333dc957b5df7356b7711a0cb 100644

--- a/media/mojo/services/media_mojo_unittest.cc

+++ b/media/mojo/services/media_mojo_unittest.cc

@@ -49,6 +49,7 @@ class MockRendererClient : public mojom::RendererClient {

MOCK_METHOD0(OnError, void());

MOCK_METHOD1(OnVideoOpacityChange, void(bool opaque));

MOCK_METHOD1(OnVideoNaturalSizeChange, void(const gfx::Size& size));

+ MOCK_METHOD1(OnDurationChange, void(int64_t));

private:

DISALLOW_COPY_AND_ASSIGN(MockRendererClient);

@@ -110,8 +111,9 @@ class MediaShellTest : public shell::test::ShellTest {

EXPECT_CALL(*this, OnRendererInitialized(expected_result))

.Times(Exactly(1))

.WillOnce(InvokeWithoutArgs(run_loop_.get(), &base::RunLoop::Quit));

renderer_->Initialize(renderer_client_binding_.CreateInterfacePtrAndBind(),

- nullptr, std::move(video_stream),

+ nullptr, std::move(video_stream), nullptr, -1,

base::Bind(&MediaShellTest::OnRendererInitialized,

base::Unretained(this)));

}