courgette/testdata/rel32_x64_01.txt - Issue 2072093003: Courgette: Extend pointer detection in x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: courgette/testdata/rel32_x64_01.txt

Issue 2072093003: Courgette: Extend pointer detection in x64. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Correct Nits in comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: courgette/testdata/rel32_x64_01.txt

diff --git a/courgette/testdata/rel32_x64_01.txt b/courgette/testdata/rel32_x64_01.txt

index 340701d8429f385a071ecbcee5066d3bd4ee156d..656365cfb2112bf9dc7fa0a0c9022050f558d814 100644

--- a/courgette/testdata/rel32_x64_01.txt

+++ b/courgette/testdata/rel32_x64_01.txt

@@ -55,8 +55,16 @@ Program:

004010C2: 4C 8D 3D 00 00 00 lea r15,[rip+00000000]

- 004010C9: 5D pop ebp

- 004010CA: C3 ret

+ 004010C9: 66 8B 05 00 00 00 mov ax,[rip+00000000]

+ 00

+ 004010D0: 66 8B 3D 00 00 00 mov di,[rip+00000000]

+ 00

+ 004010D7: 66 8D 05 00 00 00 lea ax,[rip+00000000]

+ 00

+ 004010DE: 66 8D 3D 00 00 00 lea di,[rip+00000000]

+ 00

+ 004010E5: 5D pop ebp

+ 004010E6: C3 ret

Abs32:

@@ -79,10 +87,10 @@ Expected:

1069

106F

1075

-# 107B Not yet detected.

-# 1081 Not yet detected.

-# 1087 Not yet detected.

-# 108D Not yet detected.

+107B

+1081

+1087

+108D

1094

109B

10A2

@@ -90,4 +98,8 @@ Expected:

10B0

10B7

10BE

-10C5

+10C5

+10CC

+10D3

+10DA

+10E1

« no previous file with comments | « courgette/rel32_finder_x64.cc ('k') | courgette/testdata/rel32_x64_02.txt » ('j') | no next file with comments »