chrome/browser/notifications/notification_platform_bridge_mac.mm - Issue 2070903002: Add an XPC service to handle alert notifications on mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_platform_bridge_mac.mm

Issue 2070903002: Add an XPC service to handle alert notifications on mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_builder_add_response

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/notifications/notification_platform_bridge_mac.mm

diff --git a/chrome/browser/notifications/notification_platform_bridge_mac.mm b/chrome/browser/notifications/notification_platform_bridge_mac.mm

index 5720e511e386967825ae5c001650636f69b73984..3cc13058b69224b052a853d9f67f8f80d53f12de 100644

--- a/chrome/browser/notifications/notification_platform_bridge_mac.mm

+++ b/chrome/browser/notifications/notification_platform_bridge_mac.mm

@@ -46,7 +46,7 @@

// notification#tag in NSUserNotification.identifier (10.9)

// notification#icon in NSUserNotification.contentImage (10.9)

// Site settings button is implemented as NSUserNotification's action button

-// Not possible to implement:

+// Not easy to implement:

// -notification.requireInteraction

// -The event associated to the close button

« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/browser/ui/cocoa/notifications/BUILD.gn » ('j') | no next file with comments »