Issue 20693004: Basic State Machine Logging

Issue 20693004: Basic State Machine Logging (Closed)

Created:
7 years, 4 months ago by robliao

Modified:
7 years, 4 months ago

Reviewers:
xiyuan, vadimt

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Basic State Machine Logging Added Basic State Machine Logging that will output to the console... > State Update signedIn=true geolocationEnabled=true userRespondedToToast=true > Requested Actions setToastVisible=false setShouldPollCards=true > Action Taken setShouldPollCards=true BUG=164227 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215213

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove Linebreak #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	chrome/browser/resources/google_now/background.js	View	1	4 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

vadimt

lgtm https://codereview.chromium.org/20693004/diff/1/chrome/browser/resources/google_now/background.js File chrome/browser/resources/google_now/background.js (right): https://codereview.chromium.org/20693004/diff/1/chrome/browser/resources/google_now/background.js#newcode788 chrome/browser/resources/google_now/background.js:788: Extra line.

7 years, 4 months ago (2013-08-01 23:06:08 UTC) #2

robliao

xiyuan: Please provide owner approval for background.js Thanks! https://codereview.chromium.org/20693004/diff/1/chrome/browser/resources/google_now/background.js File chrome/browser/resources/google_now/background.js (right): https://codereview.chromium.org/20693004/diff/1/chrome/browser/resources/google_now/background.js#newcode788 chrome/browser/resources/google_now/background.js:788: On ...

7 years, 4 months ago (2013-08-01 23:16:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/20693004/5001

7 years, 4 months ago (2013-08-01 23:25:24 UTC) #5

Message was sent while issue was closed.

Change committed as 215213

Expand Messages | Collapse Messages