Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2069043003:
(reland) media: Enable media_mojo_unittests on bots (Closed)
|
Created:
4 years, 6 months ago by xhwang Modified:
4 years, 6 months ago CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, alokp+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description(reland) media: Enable media_mojo_unittests on bots
This reverts commit 713cd6ebbed2081585792041aaf6cea5c704f699 and relands
72421f05b895615110d7fcc43b56e31942f34c54 with fix.
The test is only enabled on "ClangToTLinux tester".
Original CL description:
Also fix some BUILD.gn files.
TBR=jam@chromium.org,thakis@chromium.org
BUG=617204
Committed: https://crrev.com/f69024d1ddb7ee6b001203b13a019b6fc9dc7746
Cr-Commit-Position: refs/heads/master@{#400197}
Patch Set 1 : original CL #Patch Set 2 : fix #Patch Set 3 : drop test on windows (gyp) bots #
Messages
Total messages: 32 (16 generated)
Description was changed from ========== (reland) media: Enable media_mojo_unittests on bots This reverts commit 713cd6ebbed2081585792041aaf6cea5c704f699 and relands 72421f05b895615110d7fcc43b56e31942f34c54 with fix. Original CL description: Also fix some BUILD.gn files. BUG=617204 ========== to ========== (reland) media: Enable media_mojo_unittests on bots This reverts commit 713cd6ebbed2081585792041aaf6cea5c704f699 and relands 72421f05b895615110d7fcc43b56e31942f34c54 with fix. Original CL description: Also fix some BUILD.gn files. TBR=jam@chromium.org,thakis@chromium.org BUG=617204 ==========
xhwang@chromium.org changed reviewers: + jam@chromium.org, thakis@chromium.org
The CQ bit was checked by xhwang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069043003/20001
Patchset #2 (id:20001) has been deleted
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by xhwang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069043003/40001
xhwang@chromium.org changed reviewers: + jrummell@chromium.org
jrummell: Please take a look at the fixes in media/mojo/services/mojo_cdm_allocator_unittest.cc On windows bots we were getting errors about "size_t" to "uint32_t" conversion. I tested this CL on my Windows machine.
On 2016/06/15 20:48:22, xhwang wrote: > jrummell: Please take a look at the fixes in > media/mojo/services/mojo_cdm_allocator_unittest.cc > > On windows bots we were getting errors about "size_t" to "uint32_t" conversion. > > I tested this CL on my Windows machine. oops, seems there's some rebase error. I'll upload a new PS shortly.
Patchset #2 (id:40001) has been deleted
also see my comment on the original cl
On 2016/06/15 20:49:57, xhwang wrote: > On 2016/06/15 20:48:22, xhwang wrote: > > jrummell: Please take a look at the fixes in > > media/mojo/services/mojo_cdm_allocator_unittest.cc > > > > On windows bots we were getting errors about "size_t" to "uint32_t" > conversion. > > > > I tested this CL on my Windows machine. > > oops, seems there's some rebase error. I'll upload a new PS shortly. jrummell: new PS uploaded. PTAL
lgtm
The CQ bit was checked by xhwang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069043003/80001
Description was changed from ========== (reland) media: Enable media_mojo_unittests on bots This reverts commit 713cd6ebbed2081585792041aaf6cea5c704f699 and relands 72421f05b895615110d7fcc43b56e31942f34c54 with fix. Original CL description: Also fix some BUILD.gn files. TBR=jam@chromium.org,thakis@chromium.org BUG=617204 ========== to ========== (reland) media: Enable media_mojo_unittests on bots This reverts commit 713cd6ebbed2081585792041aaf6cea5c704f699 and relands 72421f05b895615110d7fcc43b56e31942f34c54 with fix. The test is only enabled on "ClangToTLinux tester". Original CL description: Also fix some BUILD.gn files. TBR=jam@chromium.org,thakis@chromium.org BUG=617204 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by xhwang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jrummell@chromium.org Link to the patchset: https://chromiumcodereview.appspot.com/2069043003/#ps80001 (title: "drop test on windows (gyp) bots")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069043003/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by xhwang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069043003/80001
Message was sent while issue was closed.
Description was changed from ========== (reland) media: Enable media_mojo_unittests on bots This reverts commit 713cd6ebbed2081585792041aaf6cea5c704f699 and relands 72421f05b895615110d7fcc43b56e31942f34c54 with fix. The test is only enabled on "ClangToTLinux tester". Original CL description: Also fix some BUILD.gn files. TBR=jam@chromium.org,thakis@chromium.org BUG=617204 ========== to ========== (reland) media: Enable media_mojo_unittests on bots This reverts commit 713cd6ebbed2081585792041aaf6cea5c704f699 and relands 72421f05b895615110d7fcc43b56e31942f34c54 with fix. The test is only enabled on "ClangToTLinux tester". Original CL description: Also fix some BUILD.gn files. TBR=jam@chromium.org,thakis@chromium.org BUG=617204 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:80001)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== (reland) media: Enable media_mojo_unittests on bots This reverts commit 713cd6ebbed2081585792041aaf6cea5c704f699 and relands 72421f05b895615110d7fcc43b56e31942f34c54 with fix. The test is only enabled on "ClangToTLinux tester". Original CL description: Also fix some BUILD.gn files. TBR=jam@chromium.org,thakis@chromium.org BUG=617204 ========== to ========== (reland) media: Enable media_mojo_unittests on bots This reverts commit 713cd6ebbed2081585792041aaf6cea5c704f699 and relands 72421f05b895615110d7fcc43b56e31942f34c54 with fix. The test is only enabled on "ClangToTLinux tester". Original CL description: Also fix some BUILD.gn files. TBR=jam@chromium.org,thakis@chromium.org BUG=617204 Committed: https://crrev.com/f69024d1ddb7ee6b001203b13a019b6fc9dc7746 Cr-Commit-Position: refs/heads/master@{#400197} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/f69024d1ddb7ee6b001203b13a019b6fc9dc7746 Cr-Commit-Position: refs/heads/master@{#400197} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
