Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: src/ast.cc

Issue 20680002: Rebase of partial ia32 implementation of optimized try/catch (started by Kevin Millikin, continued … (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix detection of CATCH frames (fixes debuger exception reporting anf breaks another assertion...). Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ast.h ('k') | src/compiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1081 matching lines...) Expand 10 before | Expand all | Expand 10 after
1092 REGULAR_NODE(Assignment) 1092 REGULAR_NODE(Assignment)
1093 REGULAR_NODE(Throw) 1093 REGULAR_NODE(Throw)
1094 REGULAR_NODE(Property) 1094 REGULAR_NODE(Property)
1095 REGULAR_NODE(UnaryOperation) 1095 REGULAR_NODE(UnaryOperation)
1096 REGULAR_NODE(CountOperation) 1096 REGULAR_NODE(CountOperation)
1097 REGULAR_NODE(BinaryOperation) 1097 REGULAR_NODE(BinaryOperation)
1098 REGULAR_NODE(CompareOperation) 1098 REGULAR_NODE(CompareOperation)
1099 REGULAR_NODE(ThisFunction) 1099 REGULAR_NODE(ThisFunction)
1100 REGULAR_NODE(Call) 1100 REGULAR_NODE(Call)
1101 REGULAR_NODE(CallNew) 1101 REGULAR_NODE(CallNew)
1102
1103 // TODO(mmassi): Work on lifting these restrictions and make TryCatch regular.
1104 // REGULAR_NODE(TryCatchStatement)
1105 void AstConstructionVisitor::VisitTryCatchStatement(TryCatchStatement* node) {
1106 increase_node_count();
1107 add_flag(kDontOsr);
1108 add_flag(kDontInline);
1109 }
1110
1102 // In theory, for VariableProxy we'd have to add: 1111 // In theory, for VariableProxy we'd have to add:
1103 // if (node->var()->IsLookupSlot()) add_flag(kDontInline); 1112 // if (node->var()->IsLookupSlot()) add_flag(kDontInline);
1104 // But node->var() is usually not bound yet at VariableProxy creation time, and 1113 // But node->var() is usually not bound yet at VariableProxy creation time, and
1105 // LOOKUP variables only result from constructs that cannot be inlined anyway. 1114 // LOOKUP variables only result from constructs that cannot be inlined anyway.
1106 REGULAR_NODE(VariableProxy) 1115 REGULAR_NODE(VariableProxy)
1107 1116
1108 // We currently do not optimize any modules. 1117 // We currently do not optimize any modules.
1109 DONT_OPTIMIZE_NODE(ModuleDeclaration) 1118 DONT_OPTIMIZE_NODE(ModuleDeclaration)
1110 DONT_OPTIMIZE_NODE(ImportDeclaration) 1119 DONT_OPTIMIZE_NODE(ImportDeclaration)
1111 DONT_OPTIMIZE_NODE(ExportDeclaration) 1120 DONT_OPTIMIZE_NODE(ExportDeclaration)
1112 DONT_OPTIMIZE_NODE(ModuleVariable) 1121 DONT_OPTIMIZE_NODE(ModuleVariable)
1113 DONT_OPTIMIZE_NODE(ModulePath) 1122 DONT_OPTIMIZE_NODE(ModulePath)
1114 DONT_OPTIMIZE_NODE(ModuleUrl) 1123 DONT_OPTIMIZE_NODE(ModuleUrl)
1115 DONT_OPTIMIZE_NODE(ModuleStatement) 1124 DONT_OPTIMIZE_NODE(ModuleStatement)
1116 DONT_OPTIMIZE_NODE(Yield) 1125 DONT_OPTIMIZE_NODE(Yield)
1117 DONT_OPTIMIZE_NODE(WithStatement) 1126 DONT_OPTIMIZE_NODE(WithStatement)
1118 DONT_OPTIMIZE_NODE(TryCatchStatement)
1119 DONT_OPTIMIZE_NODE(TryFinallyStatement) 1127 DONT_OPTIMIZE_NODE(TryFinallyStatement)
1120 DONT_OPTIMIZE_NODE(DebuggerStatement) 1128 DONT_OPTIMIZE_NODE(DebuggerStatement)
1121 DONT_OPTIMIZE_NODE(SharedFunctionInfoLiteral) 1129 DONT_OPTIMIZE_NODE(SharedFunctionInfoLiteral)
1122 1130
1123 DONT_SELFOPTIMIZE_NODE(DoWhileStatement) 1131 DONT_SELFOPTIMIZE_NODE(DoWhileStatement)
1124 DONT_SELFOPTIMIZE_NODE(WhileStatement) 1132 DONT_SELFOPTIMIZE_NODE(WhileStatement)
1125 DONT_SELFOPTIMIZE_NODE(ForStatement) 1133 DONT_SELFOPTIMIZE_NODE(ForStatement)
1126 DONT_SELFOPTIMIZE_NODE(ForInStatement) 1134 DONT_SELFOPTIMIZE_NODE(ForInStatement)
1127 DONT_SELFOPTIMIZE_NODE(ForOfStatement) 1135 DONT_SELFOPTIMIZE_NODE(ForOfStatement)
1128 1136
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
1163 OS::SNPrintF(buffer, "%d", Smi::cast(*value_)->value()); 1171 OS::SNPrintF(buffer, "%d", Smi::cast(*value_)->value());
1164 str = arr; 1172 str = arr;
1165 } else { 1173 } else {
1166 str = DoubleToCString(value_->Number(), buffer); 1174 str = DoubleToCString(value_->Number(), buffer);
1167 } 1175 }
1168 return factory->NewStringFromAscii(CStrVector(str)); 1176 return factory->NewStringFromAscii(CStrVector(str));
1169 } 1177 }
1170 1178
1171 1179
1172 } } // namespace v8::internal 1180 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ast.h ('k') | src/compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698