Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 20680002: Rebase of partial ia32 implementation of optimized try/catch (started by Kevin Millikin, continued … (Closed)

Created:
7 years, 5 months ago by Massi
Modified:
6 years, 7 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Rebase of partial ia32 implementation of optimized try/catch (started by Kevin Millikin, continued by Massimiliano Mantione) Conflicts: src/ast.h src/deoptimizer.cc src/deoptimizer.h src/hydrogen-instructions.h src/ia32/assembler-ia32.h src/ia32/deoptimizer-ia32.cc src/ia32/lithium-ia32.cc src/lithium.h src/objects.h BUG=

Patch Set 1 #

Patch Set 2 : Fixed build after merge. #

Patch Set 3 : Fixed exception object value propagation. #

Patch Set 4 : Fix build (merge was bad). #

Patch Set 5 : Avoid inlining functions with try-catch. #

Patch Set 6 : Accept execution of code just after a throw instruction. #

Patch Set 7 : Skip JS_ENTRY handlers in Isolate::PrepareForOptimizedHandler(). #

Patch Set 8 : Fix exception propagation. #

Patch Set 9 : Support inlining in methods with try-catch clauses. #

Patch Set 10 : Skip arguments above the handler. #

Patch Set 11 : Moved no-alloc scope because the above checks can throw. #

Patch Set 12 : In case of retrow do not try to prepare the optimized handler twice. #

Patch Set 13 : Fixed most of the threading-related issues (and interactions with the GC). #

Patch Set 14 : Re-fixed exception rethrowing. #

Patch Set 15 : Avoid fuzzing CatchInOptimizedCode. #

Patch Set 16 : The optimized pending exception must be stored in the isolate because the code before the call to t… #

Patch Set 17 : Properly cleanup also when the exception is not handled by JS code. #

Patch Set 18 : Added flag to disable try statement support in crankshaft. #

Patch Set 19 : Fix detection of CATCH frames (fixes debuger exception reporting anf breaks another assertion...). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+901 lines, -210 lines) Patch
M src/ast.h View 1 2 3 6 chunks +26 lines, -11 lines 0 comments Download
M src/ast.cc View 1 2 3 4 2 chunks +9 lines, -1 line 0 comments Download
M src/compiler.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M src/deoptimizer.h View 1 2 3 4 5 6 7 8 9 10 11 12 9 chunks +37 lines, -24 lines 0 comments Download
M src/deoptimizer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 16 chunks +234 lines, -37 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +2 lines, -0 lines 0 comments Download
M src/frames.h View 1 2 4 chunks +12 lines, -4 lines 0 comments Download
M src/frames.cc View 1 4 chunks +18 lines, -8 lines 0 comments Download
M src/frames-inl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 3 chunks +11 lines, -1 line 0 comments Download
M src/full-codegen.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen.h View 1 5 chunks +21 lines, -7 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 16 chunks +62 lines, -28 lines 0 comments Download
M src/hydrogen-instructions.h View 6 chunks +48 lines, -5 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +15 lines, -12 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 6 chunks +54 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.h View 4 chunks +20 lines, -3 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 2 chunks +16 lines, -4 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +10 lines, -5 lines 0 comments Download
M src/isolate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 6 chunks +83 lines, -1 line 0 comments Download
M src/isolate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 5 chunks +96 lines, -6 lines 0 comments Download
M src/lithium.h View 1 3 chunks +10 lines, -10 lines 0 comments Download
M src/objects.h View 1 2 3 5 chunks +48 lines, -28 lines 0 comments Download
M src/objects.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects-printer.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/parser.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/platform-solaris.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +38 lines, -1 line 0 comments Download
M src/runtime-profiler.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M test/mjsunit/fuzz-natives-part4.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Massi
7 years, 5 months ago (2013-07-26 09:11:38 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698