Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 20671002: set a correct breakpoint for gdbserver (Closed)

Created:
7 years, 5 months ago by yunchao
Modified:
7 years, 4 months ago
Reviewers:
borenet, djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

set a correct breakpoint for gdbserver, gdb can stop here before the app is running, and we can set more breakpoints if we need. For previous one, gdb will not stop, so it will run the app and exit. Committed: http://code.google.com/p/skia/source/detail?r=10430

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M platform_tools/android/bin/android_gdb_exe View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
yunchao
7 years, 5 months ago (2013-07-26 06:47:46 UTC) #1
djsollen
lgtm
7 years, 5 months ago (2013-07-26 12:08:31 UTC) #2
yunchao
On 2013/07/26 12:08:31, djsollen wrote: > lgtm hi, djsollen, could you help to check in ...
7 years, 5 months ago (2013-07-26 13:27:24 UTC) #3
yunchao
On 2013/07/26 13:27:24, yunchao wrote: > On 2013/07/26 12:08:31, djsollen wrote: > > lgtm > ...
7 years, 4 months ago (2013-07-30 04:47:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/yunchao.he@intel.com/20671002/3001
7 years, 4 months ago (2013-07-30 12:32:53 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-07-30 13:16:11 UTC) #6
Message was sent while issue was closed.
Change committed as 10430

Powered by Google App Engine
This is Rietveld 408576698