Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2607)

Unified Diff: build/android/findbugs_filter/findbugs_exclude.xml

Issue 20666003: [Android] Expose showFileChooser in AwContentsClient interface (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix findbugs Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/native/aw_web_contents_delegate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/findbugs_filter/findbugs_exclude.xml
diff --git a/build/android/findbugs_filter/findbugs_exclude.xml b/build/android/findbugs_filter/findbugs_exclude.xml
index ab27ae48660b0cea8bb38a0e5b845f6f4cc45513..7b6860d0bbaaf5fe80038dc40837f764face3dce 100644
--- a/build/android/findbugs_filter/findbugs_exclude.xml
+++ b/build/android/findbugs_filter/findbugs_exclude.xml
@@ -21,11 +21,16 @@ In particular, ~ at the start of a string means it's a regex.
<Match>
<Class name="~org\.chromium\.content\..*\.NativeLibraries.*?" />
</Match>
+ <!-- Ignore errors in JavaBridge due to reflection. -->
<Match>
<Class name="~.*\.JavaBridge.*"/>
- <!-- Ignore errors in JavaBridge due to reflection. -->
<Bug code="UuF,UrF,UMAC" />
</Match>
+ <!-- "Struct" like classes expect to have unused public data members -->
+ <Match>
+ <Class name="~.*android_webview.*FileChooserParams"/>
+ <Bug code="UrF" />
+ </Match>
<!-- Ignore "reliance on default String encoding" warnings, as we're not multi-platform -->
<Bug pattern="DM_DEFAULT_ENCODING" />
<!-- Ignore bugs that are often false-positives in test code -->
« no previous file with comments | « android_webview/native/aw_web_contents_delegate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698