chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm - Issue 2065943002: Abstract notification clicks in its own dictionary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm

Issue 2065943002: Abstract notification clicks in its own dictionary (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm ('k') | chrome/browser/ui/cocoa/notifications/notification_common.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm

diff --git a/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm b/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm

index 2cd92b4219fd3afd621ab276574471a3ea72f222..9baa9f55b9bd74e2a3c1f2cfbd4ba360e8020136 100644

--- a/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm

+++ b/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm

@@ -8,6 +8,7 @@

#include "base/mac/scoped_nsobject.h"

#include "base/strings/sys_string_conversions.h"

#include "chrome/browser/ui/cocoa/notifications/notification_builder_mac.h"

+#include "chrome/browser/ui/cocoa/notifications/notification_constants_mac.h"

#include "testing/gtest/include/gtest/gtest.h"

TEST(NotificationBuilderMacTest, TestNotificationNoButtons) {

@@ -115,15 +116,15 @@ TEST(NotificationBuilderMacTest, TestUserInfo) {

EXPECT_EQ("https://www.miguel.com",

base::SysNSStringToUTF8([userInfo

- objectForKey:notification_builder::kNotificationOrigin]));

+ objectForKey:notification_constants::kNotificationOrigin]));

EXPECT_EQ("Notification1",

- base::SysNSStringToUTF8(

- [userInfo objectForKey:notification_builder::kNotificationId]));

+ base::SysNSStringToUTF8([userInfo

+ objectForKey:notification_constants::kNotificationId]));

EXPECT_EQ("Profile1",

base::SysNSStringToUTF8([userInfo

- objectForKey:notification_builder::kNotificationProfileId]));

+ objectForKey:notification_constants::kNotificationProfileId]));

EXPECT_TRUE([[userInfo

- objectForKey:notification_builder::kNotificationIncognito] boolValue]);

+ objectForKey:notification_constants::kNotificationIncognito] boolValue]);

}

TEST(NotificationBuilderMacTest, TestBuildDictionary) {