Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 20655004: Fix memory leak in SkPDFResourceDict (Closed)

Created:
7 years, 4 months ago by ducky
Modified:
7 years, 4 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix memory leak in SkPDFResourceDict Committed: http://code.google.com/p/skia/source/detail?r=10499

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/pdf/SkPDFResourceDict.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ducky
This should fix the memory leak. I'm not familiar enough with the internal tools to ...
7 years, 4 months ago (2013-08-01 20:52:08 UTC) #1
edisonn
LGTM. Please run the tests again in skia too (gm, render_pdfs, ... )
7 years, 4 months ago (2013-08-01 21:00:59 UTC) #2
ducky
On 2013/08/01 21:00:59, edisonn wrote: > LGTM. Please run the tests again in skia too ...
7 years, 4 months ago (2013-08-01 21:02:17 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 4 months ago (2013-08-01 21:17:53 UTC) #4
vandebo (ex-Chrome)
LGTM too
7 years, 4 months ago (2013-08-01 21:50:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/richardlin@chromium.org/20655004/1
7 years, 4 months ago (2013-08-01 21:50:23 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-01 21:54:28 UTC) #7
Message was sent while issue was closed.
Change committed as 10499

Powered by Google App Engine
This is Rietveld 408576698