Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 20652002: Fix trailing whitespace in scripts and misc. files (Closed)

Created:
7 years, 5 months ago by Nils Barth (inactive)
Modified:
7 years, 5 months ago
Reviewers:
ojan, abarth-chromium
CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, jeez
Visibility:
Public.

Description

Fix trailing whitespace in scripts and misc. files Followup to removing trailing whitespace in .cpp, .h, and .idl files. Fixes the remaining obvious code files: .cc .gyp .gypi .pl Perl .pm Perl Module .py Python .sh Shell ...and the scripts in: Tools/Scripts Skips these, due to also having eol issues: .c C (1 file) .rb Ruby (2 files) Commands used: sed -i -E 's/\s+$//' $(git ls-files -- '*.cc' '*.gyp' '*.gypi' '*.pl' '*.pm' '*.py' '*.sh') cd Tools/Scripts && grep -l -E '\s+$' * | xargs sed -i -E 's/\s+$//' 3 manual changes: * remove trailing newline in Tools/Scripts/webkitpy/tool/steps/runtests.py * *don't* fix trailing whitespace in Tools/Scripts/webkitpy/style/checkers/python_unittest_input.py ...as this is intentional, as a test for the style checker. * *don't* fix trailing whitespace in Tools/Scripts/webkitpy/common/checkout/diff_test_data.py ...as this includes a literal diff, and unified diff uses ' ' for an unchanged blank line. The .c and .rb files with eol issues (skipped for this CL, since probably need a svn propset) are: ManualTests/NPN_Invoke/main.c Tools/Scripts/webkitruby/PrettyPatch/PrettyPatch.rb Tools/Scripts/webkitruby/PrettyPatch/diff.rb Followup to: Issue 20294002: Fix trailing whitespace in .cpp, .h, and .idl files https://codereview.chromium.org/20294002/ TBR=ojan, abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154989

Patch Set 1 #

Patch Set 2 : Don't fix *intentional* errors! #

Patch Set 3 : Rebased #

Patch Set 4 : Revert ManualTests/NPN_Invoke/main.c #

Patch Set 5 : Remove .rb (eol problems) #

Patch Set 6 : Don't change literal diff. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1161 lines, -1162 lines) Patch
M LayoutTests/http/tests/navigation/resources/frameset.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/navigation/resources/redirect-cycle-1.pl View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/navigation/resources/redirect-to-go-back.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/navigation/resources/reload-subframe.pl View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/resources/echo-intertag.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/resources/echo-intertag-decode-16bit-unicode.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-mismatch-protocol-header_wsh.py View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-more-accept-header_wsh.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/WebKitUnitTests.gyp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/features.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/scripts/Hasher.pm View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/scripts/InFilesCompiler.pm View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/scripts/InFilesParser.pm View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/scripts/StaticString.pm View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/scripts/action_makenames.py View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/scripts/action_useragentstylesheets.py View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/scripts/check_objc_rename.sh View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/scripts/make_names.pl View 10 chunks +14 lines, -14 lines 0 comments Download
M Source/core/scripts/rule_bison.py View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/wtf/dtoa/bignum.cc View 34 chunks +95 lines, -95 lines 0 comments Download
M Source/wtf/dtoa/bignum-dtoa.cc View 26 chunks +42 lines, -42 lines 0 comments Download
M Source/wtf/dtoa/cached-powers.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/wtf/dtoa/diy-fp.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/dtoa/double-conversion.cc View 29 chunks +73 lines, -73 lines 0 comments Download
M Source/wtf/dtoa/fast-dtoa.cc View 23 chunks +33 lines, -33 lines 0 comments Download
M Source/wtf/dtoa/fixed-dtoa.cc View 14 chunks +29 lines, -29 lines 0 comments Download
M Source/wtf/dtoa/strtod.cc View 20 chunks +35 lines, -35 lines 0 comments Download
M Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M Tools/Scripts/SpacingHeuristics.pm View 2 chunks +4 lines, -4 lines 0 comments Download
M Tools/Scripts/VCSUtils.pm View 8 chunks +17 lines, -17 lines 0 comments Download
M Tools/Scripts/add-include View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/bencher View 69 chunks +325 lines, -325 lines 0 comments Download
M Tools/Scripts/bisect-builds View 1 chunk +3 lines, -3 lines 0 comments Download
M Tools/Scripts/check-dom-results View 4 chunks +6 lines, -6 lines 0 comments Download
M Tools/Scripts/check-for-exit-time-destructors View 1 chunk +3 lines, -3 lines 0 comments Download
M Tools/Scripts/check-for-global-initializers View 1 chunk +3 lines, -3 lines 0 comments Download
M Tools/Scripts/check-for-inappropriate-objc-class-names View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/check-for-weak-vtables-and-externals View 1 chunk +3 lines, -3 lines 0 comments Download
M Tools/Scripts/clean-header-guards View 3 chunks +6 lines, -6 lines 0 comments Download
M Tools/Scripts/compare-timing-files View 2 chunks +2 lines, -2 lines 0 comments Download
M Tools/Scripts/configure-github-as-upstream View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/display-profiler-output View 42 chunks +75 lines, -75 lines 0 comments Download
M Tools/Scripts/do-file-rename View 1 chunk +3 lines, -3 lines 0 comments Download
M Tools/Scripts/do-webcore-rename View 1 chunk +3 lines, -3 lines 0 comments Download
M Tools/Scripts/ensure-valid-python View 1 chunk +3 lines, -3 lines 0 comments Download
M Tools/Scripts/find-extra-includes View 1 chunk +3 lines, -3 lines 0 comments Download
M Tools/Scripts/malloc-tree View 2 chunks +2 lines, -2 lines 0 comments Download
M Tools/Scripts/parse-malloc-history View 5 chunks +9 lines, -9 lines 0 comments Download
M Tools/Scripts/report-include-statistics View 1 chunk +3 lines, -3 lines 0 comments Download
M Tools/Scripts/sampstat View 2 chunks +2 lines, -2 lines 0 comments Download
M Tools/Scripts/split-file-by-class View 7 chunks +11 lines, -11 lines 0 comments Download
M Tools/Scripts/svn-apply View 2 chunks +2 lines, -2 lines 0 comments Download
M Tools/Scripts/svn-create-patch View 4 chunks +8 lines, -8 lines 0 comments Download
M Tools/Scripts/svn-unapply View 2 chunks +6 lines, -6 lines 0 comments Download
M Tools/Scripts/sync-master-with-upstream View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/test-webkitperl View 2 chunks +2 lines, -2 lines 0 comments Download
M Tools/Scripts/validate-committer-lists View 3 chunks +3 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitdirs.pm View 13 chunks +15 lines, -15 lines 0 comments Download
M Tools/Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl View 32 chunks +73 lines, -73 lines 0 comments Download
M Tools/Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl View 3 chunks +4 lines, -4 lines 0 comments Download
M Tools/Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl View 2 chunks +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl View 3 chunks +11 lines, -11 lines 0 comments Download
M Tools/Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl View 20 chunks +20 lines, -20 lines 0 comments Download
M Tools/Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl View 2 chunks +4 lines, -4 lines 0 comments Download
M Tools/Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl View 1 chunk +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl View 2 chunks +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl View 2 chunks +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl View 4 chunks +4 lines, -4 lines 0 comments Download
M Tools/Scripts/webkitpy/common/config/ports_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/common/net/credentials_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/system/user.py View 2 chunks +3 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/thirdparty/unittest2/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/thirdparty/unittest2/case.py View 19 chunks +38 lines, -38 lines 0 comments Download
M Tools/Scripts/webkitpy/thirdparty/unittest2/compatibility.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/thirdparty/unittest2/loader.py View 2 chunks +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/thirdparty/unittest2/main.py View 4 chunks +6 lines, -6 lines 0 comments Download
M Tools/Scripts/webkitpy/thirdparty/unittest2/result.py View 5 chunks +6 lines, -6 lines 0 comments Download
M Tools/Scripts/webkitpy/thirdparty/unittest2/runner.py View 3 chunks +3 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/thirdparty/unittest2/signals.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/thirdparty/unittest2/suite.py View 7 chunks +17 lines, -17 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py View 2 chunks +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/multicommandtool.py View 2 chunks +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/steps/abstractstep.py View 2 chunks +3 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/steps/applypatch.py View 2 chunks +3 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/steps/checkstyle.py View 2 chunks +3 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py View 2 chunks +3 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/steps/commit.py View 2 chunks +3 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/steps/confirmdiff.py View 2 chunks +3 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py View 2 chunks +3 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/steps/haslanded_unittest.py View 10 chunks +10 lines, -10 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/steps/metastep.py View 2 chunks +3 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/steps/obsoletepatches.py View 2 chunks +3 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/steps/postdiff.py View 2 chunks +3 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/steps/promptforbugortitle.py View 2 chunks +3 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/steps/reopenbugafterrollout.py View 2 chunks +3 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/steps/revertrevision.py View 2 chunks +3 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/steps/runtests.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Nils Barth (inactive)
Hi Ojan, Followup trailing whitespace fix to other files; should be straightforward.
7 years, 5 months ago (2013-07-26 03:28:18 UTC) #1
ojan
rubberstamp lgtm On Thu, Jul 25, 2013 at 8:28 PM, <nbarth@chromium.org> wrote: > Reviewers: ojan, ...
7 years, 5 months ago (2013-07-26 03:31:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/20652002/6001
7 years, 5 months ago (2013-07-26 03:33:47 UTC) #3
commit-bot: I haz the power
Failed to apply patch for ManualTests/NPN_Invoke/main.c: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 5 months ago (2013-07-26 03:34:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/20652002/11001
7 years, 5 months ago (2013-07-26 04:44:16 UTC) #5
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=4292
7 years, 5 months ago (2013-07-26 05:23:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/20652002/17001
7 years, 5 months ago (2013-07-26 05:25:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/20652002/31001
7 years, 5 months ago (2013-07-26 06:16:41 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=14826
7 years, 5 months ago (2013-07-26 08:25:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/20652002/31001
7 years, 5 months ago (2013-07-26 09:33:20 UTC) #10
commit-bot: I haz the power
7 years, 5 months ago (2013-07-26 10:57:24 UTC) #11
Message was sent while issue was closed.
Change committed as 154989

Powered by Google App Engine
This is Rietveld 408576698