Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Unified Diff: media/filters/gpu_video_decoder.h

Issue 2064083002: media: Add Rappor reporting in MediaLog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more fixes Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/gpu_video_decoder.h
diff --git a/media/filters/gpu_video_decoder.h b/media/filters/gpu_video_decoder.h
index 159381bfab3a3d70001b319f3b8c1970ab462527..7de2e5575869b4f6ffcdd0724454ece3dd957e2b 100644
--- a/media/filters/gpu_video_decoder.h
+++ b/media/filters/gpu_video_decoder.h
@@ -46,8 +46,9 @@ class MEDIA_EXPORT GpuVideoDecoder
: public VideoDecoder,
public VideoDecodeAccelerator::Client {
public:
- explicit GpuVideoDecoder(GpuVideoAcceleratorFactories* factories,
- const RequestSurfaceCB& request_surface_cb);
+ GpuVideoDecoder(GpuVideoAcceleratorFactories* factories,
+ const RequestSurfaceCB& request_surface_cb,
+ scoped_refptr<MediaLog> media_log);
// VideoDecoder implementation.
std::string GetDisplayName() const override;
@@ -158,6 +159,12 @@ class MEDIA_EXPORT GpuVideoDecoder
GpuVideoAcceleratorFactories* factories_;
+ // For requesting a suface to render to. If this is null the VDA will return
+ // normal video frames and not render them to a surface.
+ RequestSurfaceCB request_surface_cb_;
+
+ scoped_refptr<MediaLog> media_log_;
+
// Populated during Initialize() (on success) and unchanged until an error
// occurs.
std::unique_ptr<VideoDecodeAccelerator> vda_;
@@ -174,10 +181,6 @@ class MEDIA_EXPORT GpuVideoDecoder
VideoDecoderConfig config_;
- // For requesting a suface to render to. If this is null the VDA will return
- // normal video frames and not render them to a surface.
- RequestSurfaceCB request_surface_cb_;
-
// Shared-memory buffer pool. Since allocating SHM segments requires a
// round-trip to the browser process, we keep allocation out of the
// steady-state of the decoder.

Powered by Google App Engine
This is Rietveld 408576698