Add anonymous-only option to apply_issue

third_party/upload.py

Index: third_party/upload.py
diff --git a/third_party/upload.py b/third_party/upload.py
index b2a5193ad850204070059bf9b549bae497a14c7e..744f3d6794d9c1010b1b3cc0b853df3d91aa5116 100755
--- a/third_party/upload.py
+++ b/third_party/upload.py
@@ -424,7 +424,7 @@ class AbstractRpcServer(object):
     """
     # TODO: Don't require authentication.  Let the server say
     # whether it is necessary.
-    if not self.authenticated:
+    if not self.authenticated and self.auth_function:

[M-A Ruel, 2013/07/26 11:05:20]

Please remove the todo and upstream this first.

[Isaac (away), 2013/07/26 11:08:03]

I assumed the TODO was about removing lines 427 and 428 -- wouldn't it still
apply?

I'll work on adding this to rietveld codebase first.

[M-A Ruel, 2013/07/26 11:09:24]

Yeah, ignore.

       self._Authenticate()
 
     old_timeout = socket.getdefaulttimeout()
@@ -451,6 +451,8 @@ class AbstractRpcServer(object):
           if tries > 3:
             raise
           elif e.code == 401 or e.code == 302:
+            if not self.auth_function:
+              raise
             self._Authenticate()
           elif e.code == 301:
             # Handle permanent redirect manually.