Add anonymous-only option to apply_issue

Add anonymous-only option to apply_issue

Add an option to apply_issue to fail if anonymous access
triggers a login prompt.
- cherry-pick upload.py rietveld cl 37c73ece82d0 which
   allows clients to request no authentication.

BUG=240634
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=214023

[M-A Ruel, 2013-07-26 11:05:20]

Mostly fine but I'd prefer upload.py to be properly changed upstream first. I or
Robert can help with that.

https://chromiumcodereview.appspot.com/20634003/diff/1/third_party/upload.py
File third_party/upload.py (right):

https://chromiumcodereview.appspot.com/20634003/diff/1/third_party/upload.py#...
third_party/upload.py:427: if not self.authenticated and self.auth_function:
Please remove the todo and upstream this first.

[Isaac (away), 2013-07-26 11:08:03]

https://chromiumcodereview.appspot.com/20634003/diff/1/third_party/upload.py
File third_party/upload.py (right):

https://chromiumcodereview.appspot.com/20634003/diff/1/third_party/upload.py#...
third_party/upload.py:427: if not self.authenticated and self.auth_function:
On 2013/07/26 11:05:20, Marc-Antoine Ruel wrote:
> Please remove the todo and upstream this first.

I assumed the TODO was about removing lines 427 and 428 -- wouldn't it still
apply?

I'll work on adding this to rietveld codebase first.

[M-A Ruel, 2013-07-26 11:09:24]

https://chromiumcodereview.appspot.com/20634003/diff/1/third_party/upload.py
File third_party/upload.py (right):

https://chromiumcodereview.appspot.com/20634003/diff/1/third_party/upload.py#...
third_party/upload.py:427: if not self.authenticated and self.auth_function:
On 2013/07/26 11:08:03, Isaac wrote:
> On 2013/07/26 11:05:20, Marc-Antoine Ruel wrote:
> > Please remove the todo and upstream this first.
> 
> I assumed the TODO was about removing lines 427 and 428 -- wouldn't it still
> apply?

Yeah, ignore.

[Isaac (away), 2013-07-26 23:20:27]

OK -- landed third_party/upload.py patch upstream.  This patch now cherry-picks
the change into depot_tools.

[M-A Ruel, 2013-07-27 00:07:02]

Can you note in the CL description at which commit hash you sync upload.py?
Thanks.

lgtm

[Isaac (away), 2013-07-27 00:16:11]

Done.  Thanks for the review -- sending to CQ.

[commit-bot: I haz the power, 2013-07-27 00:17:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/20634003/8001

[commit-bot: I haz the power, 2013-07-27 00:18:42]

Presubmit check for 20634003-8001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
push-basic.sh failed
Command /b/commit-queue/workdir/tools/depot_tools/tests/push-basic.sh returned
non-zero exit status 1 in /b/commit-queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   1541 --:--:-- --:--:-- --:--:--  1571
TESTING: Base URL contains branch name
TESTING: git-cl push ok
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description: 'foo-quux\n\nReview URL: http://localhost:8080/5629499534213120'
Closing issue (you may be prompted for your codereview password)...
TESTING: committed code has proper description
TESTING: issue no longer has a branch
FAILURE: issue no longer has a branch


basic.sh failed
Command /b/commit-queue/workdir/tools/depot_tools/tests/basic.sh returned
non-zero exit status 1 in /b/commit-queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   1785 --:--:-- --:--:-- --:--:--  1833
TESTING: git-cl dcommits ok
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description: 'foo-quux\n\nReview URL: http://localhost:8080/5840605766746112'
Closing issue (you may be prompted for your codereview password)...
TESTING: dcommitted code has proper description
TESTING: issue no longer has a branch
FAILURE: issue no longer has a branch


Presubmit checks took 85.9s to calculate.

[commit-bot: I haz the power, 2013-07-27 02:30:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/20634003/8001

[commit-bot: I haz the power, 2013-07-27 02:32:13]

Change committed as 214023