Add media::VideoEncodeAccelerator with WebRTC integration

content/common/gpu/media/gpu_video_encode_accelerator.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/common/gpu/media/gpu_video_encode_accelerator.h"
+
+#include "base/logging.h"
+#include "base/memory/shared_memory.h"
+#include "content/common/gpu/gpu_channel.h"
+#include "content/common/gpu/gpu_messages.h"
+#include "ipc/ipc_message_macros.h"
+#include "media/base/video_frame.h"
+
+namespace content {
+
+GpuVideoEncodeAccelerator::GpuVideoEncodeAccelerator(GpuChannel* gpu_channel,
+                                                     int32 route_id)
+    : channel_(gpu_channel),
+      route_id_(route_id),
+      input_format_(media::VideoFrame::INVALID),
+      output_buffer_size_(0) {}
+
+GpuVideoEncodeAccelerator::~GpuVideoEncodeAccelerator() {
+  if (encoder_)
+    encoder_.release()->Destroy();
+}
+
+bool GpuVideoEncodeAccelerator::OnMessageReceived(const IPC::Message& message) {
+  bool handled = true;
+  IPC_BEGIN_MESSAGE_MAP(GpuVideoEncodeAccelerator, message)
+    IPC_MESSAGE_HANDLER(AcceleratedVideoEncoderMsg_Initialize, OnInitialize)
+    IPC_MESSAGE_HANDLER(AcceleratedVideoEncoderMsg_Encode, OnEncode)
+    IPC_MESSAGE_HANDLER(AcceleratedVideoEncoderMsg_UseOutputBitstreamBuffer,
+                        OnUseOutputBitstreamBuffer)
+    IPC_MESSAGE_HANDLER(
+        AcceleratedVideoEncoderMsg_RequestEncodingParameterChange,
+        OnRequestEncodingParameterChange)
+    IPC_MESSAGE_UNHANDLED(handled = false)
+  IPC_END_MESSAGE_MAP()
+  return handled;
+}
+
+void GpuVideoEncodeAccelerator::OnChannelError() {
+  NotifyError(media::VideoEncodeAccelerator::kPlatformFailureError);
+  if (channel_)
+    channel_ = NULL;
+}
+
+void GpuVideoEncodeAccelerator::NotifyInitializeDone() {
+  Send(new AcceleratedVideoEncoderHostMsg_NotifyInitializeDone(route_id_));
+}
+
+void GpuVideoEncodeAccelerator::RequireBitstreamBuffers(
+    int input_count,
+    const gfx::Size& input_coded_size,
+    size_t output_buffer_size) {
+  Send(new AcceleratedVideoEncoderHostMsg_RequireBitstreamBuffers(
+      route_id_, input_count, input_coded_size, output_buffer_size));
+  input_coded_size_ = input_coded_size;
+  output_buffer_size_ = output_buffer_size;
+}
+
+void GpuVideoEncodeAccelerator::NotifyInputDone(int32 bitstream_buffer_id) {

[Ami GONE FROM CHROMIUM, 2013/08/05 18:44:38]

This is dead code (no callers).
Which makes me wonder how the pipeline isn't stalling as the GVEAHost should be
holding on to VideoFrames not releasing them, which should make the
VideoCaptureBufferPool run out of buffers pretty quickly waiting for them to be
returned from the renderer.  

[Ami GONE FROM CHROMIUM, 2013/08/05 18:44:38]

If this undeads, it probably wants to be renamed to NotifyEncodeDone.

[Ami GONE FROM CHROMIUM, 2013/08/05 18:44:38]

s/bitstream_buffer_id/frame_id/ here and below.

[sheu, 2013/08/06 06:16:36]

(see comment below, which I posted when uploading this)

+  Send(new AcceleratedVideoEncoderHostMsg_NotifyEncodeDone(
+      route_id_, bitstream_buffer_id));
+}

[sheu, 2013/08/03 02:37:01]

Whoops, I missed updating this to account for the media::VideoFrame interface
now.

FINV

+
+void GpuVideoEncodeAccelerator::BitstreamBufferReady(int32 bitstream_buffer_id,
+                                                     size_t payload_size,
+                                                     bool key_frame) {
+  Send(new AcceleratedVideoEncoderHostMsg_BitstreamBufferReady(
+      route_id_, bitstream_buffer_id, payload_size, key_frame));
+}
+
+void GpuVideoEncodeAccelerator::NotifyError(
+    media::VideoEncodeAccelerator::Error error) {
+  Send(new AcceleratedVideoEncoderHostMsg_NotifyError(route_id_, error));
+}
+
+// static
+std::vector<media::VideoEncodeAccelerator::SupportedProfile>
+GpuVideoEncodeAccelerator::GetSupportedProfiles() {
+  std::vector<media::VideoEncodeAccelerator::SupportedProfile> profiles;
+
+  // TODO(sheu): return platform-specific profiles.
+  return profiles;
+}
+
+void GpuVideoEncodeAccelerator::CreateEncoder() {
+  // TODO(sheu): actual create the encoder.
+}
+
+void GpuVideoEncodeAccelerator::OnInitialize(
+    media::VideoFrame::Format input_format,
+    const gfx::Size& input_visible_size,
+    media::VideoCodecProfile output_profile,
+    int32 initial_bitrate) {
+  DVLOG(2) << "GpuVideoEncodeAccelerator::OnInitialize(): "
+              "input_format=" << input_format
+           << ", input_visible_size=" << input_visible_size.ToString()
+           << ", output_profile=" << output_profile
+           << ", initial_bitrate=" << initial_bitrate;
+  DCHECK(!encoder_);
+
+  CreateEncoder();
+  if (!encoder_) {
+    DLOG(ERROR) << "GpuVideoEncodeAccelerator::OnInitialize(): VEA creation "
+                   "failed";
+    NotifyError(media::VideoEncodeAccelerator::kPlatformFailureError);
+    return;
+  }
+  encoder_->Initialize(
+      input_format, input_visible_size, output_profile, initial_bitrate);
+  input_format_ = input_format;
+  input_visible_size_ = input_visible_size;
+}
+
+void GpuVideoEncodeAccelerator::OnEncode(int32 frame_id,
+                                         base::SharedMemoryHandle buffer_handle,
+                                         uint32 buffer_size,
+                                         bool force_keyframe) {
+  DVLOG(3) << "GpuVideoEncodeAccelerator::OnEncode(): frame_id=" << frame_id
+           << ", buffer_size=" << buffer_size
+           << ", force_keyframe=" << force_keyframe;
+  if (!encoder_)
+    return;
+  if (frame_id < 0) {
+    DLOG(ERROR) << "GpuVideoEncodeAccelerator::OnEncode(): invalid frame_id="
+                << frame_id;
+    NotifyError(media::VideoEncodeAccelerator::kInvalidArgumentError);
+    return;
+  }
+
+  scoped_ptr<base::SharedMemory> shm(

[Ami GONE FROM CHROMIUM, 2013/08/05 18:44:38]

Can stack-allocate instead of heap-allocate.

[sheu, 2013/08/06 06:16:36]

It gets passed to EncodeFrameFinished.  Stack-allocating would be interesting.

+      new base::SharedMemory(buffer_handle, true));
+  if (!shm->Map(buffer_size)) {
+    DLOG(ERROR) << "GpuVideoEncodeAccelerator::OnEncode(): "
+                   "could not map frame_id=" << frame_id;
+    NotifyError(media::VideoEncodeAccelerator::kPlatformFailureError);
+    return;
+  }
+
+  scoped_refptr<media::VideoFrame> frame;
+  switch (input_format_) {
+    case media::VideoFrame::I420: {
+      if (buffer_size <
+          static_cast<size_t>(input_coded_size_.GetArea() * 3 / 2)) {
+        DLOG(ERROR) << "GpuVideoEncodeAccelerator::OnEncode(): "
+                       "buffer too small for frame_id=" << frame_id;
+        NotifyError(media::VideoEncodeAccelerator::kInvalidArgumentError);
+        return;
+      }
+      uint8* data = reinterpret_cast<uint8*>(shm->memory());
+      frame = media::VideoFrame::WrapExternalYuvData(
+          media::VideoFrame::I420,
+          input_coded_size_,
+          gfx::Rect(input_visible_size_),
+          input_visible_size_,
+          input_coded_size_.width(),
+          input_coded_size_.width() / 2,
+          input_coded_size_.width() / 2,
+          data,
+          data + input_coded_size_.GetArea(),
+          data + (input_coded_size_.GetArea() * 5 / 4),
+          base::TimeDelta(),
+          buffer_handle,
+          base::Bind(&GpuVideoEncodeAccelerator::EncodeFrameFinished,
+                     base::Unretained(this),
+                     base::Passed(&shm)));
+    }

[Ami GONE FROM CHROMIUM, 2013/08/05 18:44:38]

How does this fall-through not completely break your testing?

[sheu, 2013/08/06 06:16:36]

Easy -- I didn't test :-P

Fixed now that I actually tested

+    default:
+      NOTREACHED();

[Ami GONE FROM CHROMIUM, 2013/08/05 18:44:38]

It's kind of silly to have a single-case switch statement.
You could replace it with detecting != I420 in OnInitialize and error out early,
and then have a DCHECK before you assume I420 for the first time in this method.
(gets you a -4 de-indent for the bulk of this method)

[sheu, 2013/08/06 06:16:36]

It's silly but I intend to be taking more formats in the future, so I think this
is a nice self-documenting way of saying "future format support goes here".

[Ami GONE FROM CHROMIUM, 2013/08/06 20:41:13]

If this alleged future is in less than 30d, then ok.  Otherwise I call BS.

+      NotifyError(media::VideoEncodeAccelerator::kInvalidArgumentError);
+      return;
+  }
+
+  encoder_->Encode(frame, force_keyframe);
+}
+
+void GpuVideoEncodeAccelerator::OnUseOutputBitstreamBuffer(
+    int32 buffer_id,
+    base::SharedMemoryHandle buffer_handle,
+    uint32 buffer_size) {
+  DVLOG(3) << "GpuVideoEncodeAccelerator::OnUseOutputBitstreamBuffer(): "
+              "buffer_id=" << buffer_id
+           << ", buffer_size=" << buffer_size;
+  if (!encoder_)
+    return;
+  if (buffer_id < 0) {
+    DLOG(ERROR) << "GpuVideoEncodeAccelerator::OnUseOutputBitstreamBuffer(): "

[Ami GONE FROM CHROMIUM, 2013/08/05 18:44:38]

nit: DLOG will emit the file:line pair for this; hard-coding class/method names
seems silly (it's brittle as you found out here, it takes up your readers'
mind-share, and it occupies screen real-estate)

[sheu, 2013/08/06 06:16:36]

I suppose.  Search-replace time.

+                   "invalid buffer_id=" << buffer_id;
+    NotifyError(media::VideoEncodeAccelerator::kInvalidArgumentError);
+    return;
+  }
+  if (buffer_size < output_buffer_size_) {
+    DLOG(ERROR) << "GpuVideoEncodeAccelerator::OnUseOutputBitstreamBuffer(): "
+                   "buffer too small for buffer_id=" << buffer_id;
+    NotifyError(media::VideoEncodeAccelerator::kInvalidArgumentError);
+    return;
+  }
+  encoder_->UseOutputBitstreamBuffer(
+      media::BitstreamBuffer(buffer_id, buffer_handle, buffer_size));
+}
+
+void GpuVideoEncodeAccelerator::OnRequestEncodingParameterChange(
+    int32 bitrate) {
+  DVLOG(2) << "GpuVideoEncodeAccelerator::OnRequestEncodingParametersChange(): "
+              "bitrate=" << bitrate;
+  if (!encoder_)
+    return;
+  encoder_->RequestEncodingParameterChange(bitrate);
+}
+
+void GpuVideoEncodeAccelerator::Send(IPC::Message* message) {
+  if (!channel_) {
+    DLOG(ERROR) << "GpuVideoEncodeAccelerator::Send(): no channel";
+    delete message;
+    return;
+  } else if (!channel_->Send(message)) {
+    DLOG(ERROR) << "GpuVideoEncodeAccelerator::Send(): sending failed: "
+                   "message->type()=" << message->type();
+    NotifyError(media::VideoEncodeAccelerator::kPlatformFailureError);
+    return;
+  }
+}
+
+void GpuVideoEncodeAccelerator::EncodeFrameFinished(
+    scoped_ptr<base::SharedMemory> shm) {
+  // Just let shm fall out of scope.
+}
+
+}  // namespace content