Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 20625004: XMLHttpRequest should clear the response encoding when it clears responseText. (Closed)

Created:
7 years, 5 months ago by yhirano
Modified:
7 years, 4 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

XMLHttpRequest should clear the response encoding if it clears responseText. XMLHttpRequest did not clear the response encoding when it have should, for example, when abort() is called. This caused character corruption in responseText if we re-opened the XHR object. BUG=261140 R=abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155008

Patch Set 1 #

Patch Set 2 : Fix the layout test #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
A LayoutTests/http/tests/xmlhttprequest/reopen-encoding.html View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/reopen-encoding-expected.txt View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/resources/get-utf-8.cgi View 1 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/resources/get-windows-1251.cgi View 1 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yhirano
7 years, 5 months ago (2013-07-26 04:32:16 UTC) #1
yhirano
This CL clears m_responseEncoding when the XHR object finishes loading, too. I think it is ...
7 years, 5 months ago (2013-07-26 05:03:52 UTC) #2
abarth-chromium
lgtm
7 years, 5 months ago (2013-07-26 16:59:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/20625004/6001
7 years, 5 months ago (2013-07-26 17:06:53 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=18602
7 years, 5 months ago (2013-07-26 19:21:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/20625004/6001
7 years, 5 months ago (2013-07-26 19:42:28 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-07-26 20:58:58 UTC) #7
Message was sent while issue was closed.
Change committed as 155008

Powered by Google App Engine
This is Rietveld 408576698