Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 2061393002: media: Fix a typo in PipelineError rappor reporting (Closed)

Created:
4 years, 6 months ago by xhwang
Modified:
4 years, 6 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Fix a typo in PipelineError rappor reporting Apparently I was missing a "." :( BUG=607949 TEST=Verified the name is correct now. Committed: https://crrev.com/0b81daa043ac6c4aeecd2a99aa055ac20fdc6511 Cr-Commit-Position: refs/heads/master@{#399846}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/blink/webmediaplayer_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
xhwang
PTAL
4 years, 6 months ago (2016-06-15 00:12:20 UTC) #2
DaleCurtis
lgtm, but shouldn't this just report w/o the period? Or is there an XML whitelist ...
4 years, 6 months ago (2016-06-15 00:30:04 UTC) #3
xhwang
On 2016/06/15 00:30:04, DaleCurtis wrote: > lgtm, but shouldn't this just report w/o the period? ...
4 years, 6 months ago (2016-06-15 00:33:10 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061393002/1
4 years, 6 months ago (2016-06-15 00:33:47 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/110130)
4 years, 6 months ago (2016-06-15 01:09:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061393002/1
4 years, 6 months ago (2016-06-15 02:35:40 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 05:08:35 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 05:08:39 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 05:10:22 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b81daa043ac6c4aeecd2a99aa055ac20fdc6511
Cr-Commit-Position: refs/heads/master@{#399846}

Powered by Google App Engine
This is Rietveld 408576698