Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20609004: [Downloads] Some UMA for downloads resumption. (Closed)

Created:
7 years, 5 months ago by asanka
Modified:
7 years, 4 months ago
CC:
chromium-reviews, jar (doing other things), benjhayden+dwatch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, Ilya Sherman, Alexei Svitkine (slow), Mark P
Visibility:
Public.

Description

[Downloads] Some UMA for downloads resumption. * Count number of requests initiated due to resumption. * Count downloads that have a strong validator and supports range requests, since those are candidates for partial resumption. * Count downloads that are interrupted after the associated WebContents is destroyed. BUG=7648 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214461

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -8 lines) Patch
M content/browser/download/download_item_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/download/download_item_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_manager_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/download/download_resource_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/download/download_resource_handler.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M content/browser/download/download_stats.h View 3 chunks +20 lines, -2 lines 0 comments Download
M content/browser/download/download_stats.cc View 2 chunks +6 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
asanka
ben: /download/ jar: histograms.xml Tested with about:histograms.
7 years, 5 months ago (2013-07-26 16:10:10 UTC) #1
jar (doing other things)
histograms.xml LGTM
7 years, 5 months ago (2013-07-26 16:28:36 UTC) #2
benjhayden
lgtm
7 years, 5 months ago (2013-07-26 17:05:55 UTC) #3
asanka
On 2013/07/26 17:05:55, benjhayden_chromium wrote: > lgtm Thanks everyone!
7 years, 5 months ago (2013-07-26 17:07:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/20609004/9001
7 years, 5 months ago (2013-07-26 19:42:05 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=63919
7 years, 4 months ago (2013-07-28 00:58:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/20609004/9001
7 years, 4 months ago (2013-07-29 05:24:20 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=64375
7 years, 4 months ago (2013-07-29 07:19:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/20609004/9001
7 years, 4 months ago (2013-07-29 21:59:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/20609004/9001
7 years, 4 months ago (2013-07-30 03:29:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/20609004/9001
7 years, 4 months ago (2013-07-30 15:05:22 UTC) #11
commit-bot: I haz the power
7 years, 4 months ago (2013-07-30 23:02:30 UTC) #12
Message was sent while issue was closed. 
Change committed as 214461

Powered by Google App Engine
This is Rietveld 408576698