Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Issue 20607005: Fix mozilla regress-398085-01 failure on windows. (Closed)

Created:
7 years, 4 months ago by ulan
Modified:
7 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix mozilla regress-398085-01 failure on windows. Make sure that all stack pages are mapped before accessing them. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16007

Patch Set 1 #

Patch Set 2 : Remove redundant comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -18 lines) Patch
M src/ia32/lithium-codegen-ia32.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 3 chunks +14 lines, -9 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 3 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL
7 years, 4 months ago (2013-08-01 12:45:12 UTC) #1
Jakob Kummerow
lgtm
7 years, 4 months ago (2013-08-01 12:54:18 UTC) #2
ulan
7 years, 4 months ago (2013-08-01 12:55:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16007.

Powered by Google App Engine
This is Rietveld 408576698