Issue 20598004: Do not hide the web notification popups by the system tray, rather let them avoid (2nd)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20598004: Do not hide the web notification popups by the system tray, rather let them avoid (2nd) (Closed)

Created:
7 years, 4 months ago by Jun Mukai

Modified:
7 years, 4 months ago

Reviewers:
stevenjb, dewittj

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Do not hide the web notification popups by the system tray, rather let them avoid (2nd) The previous CL was reverted due to test failure in win8_aura. BUG=181011 TBR=stevenjb@chromium.org, dewittj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215164

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+203 lines, -27 lines)			Patch
M	ash/system/status_area_widget.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	ash/system/status_area_widget.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	ash/system/tray/system_tray.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	ash/system/tray/system_tray.cc	View	2	4 chunks	+28 lines, -3 lines	0 comments	Download
M	ash/system/web_notification/web_notification_tray.h	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	ash/system/web_notification/web_notification_tray.cc	View	1	8 chunks	+44 lines, -9 lines	0 comments	Download
M	ash/system/web_notification/web_notification_tray_unittest.cc	View	1 2	6 chunks	+118 lines, -5 lines	0 comments	Download
M	ui/message_center/views/message_popup_collection.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Jun Mukai

Submitting with TBR. The difference from the last (reverted) one is to disable popupAndSystemTray test ...

7 years, 4 months ago (2013-08-01 21:26:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/20598004/7001

7 years, 4 months ago (2013-08-01 21:27:49 UTC) #2

Message was sent while issue was closed.

Change committed as 215164