Chromium Code Reviews
Help | Chromium Project | Sign in
(659)

Issue 20592003: Updates web-ui to match SDK 0.6.13 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 7 months ago by Siggi Cherem (dart-lang)
Modified:
1 year, 7 months ago
Reviewers:
John Messerly
CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web-ui.git@master
Visibility:
Public.

Description

Updates web-ui to match SDK 0.6.13 Committed: https://github.com/dart-lang/web-ui/commit/5ebff91

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M lib/web_ui.dart View 2 chunks +9 lines, -3 lines 0 comments Download
Trybot results:
Commit:

Messages

Total messages: 5 (0 generated)
Siggi Cherem (dart-lang)
tbr
1 year, 7 months ago (2013-08-01 17:26:52 UTC) #1
Siggi Cherem (dart-lang)
Committed patchset #1 manually as r5ebff91 (presubmit successful).
1 year, 7 months ago (2013-08-01 17:27:08 UTC) #2
John Messerly
Crazy idea here (actually, 2 crazy ideas): * Could we switch this proxy to use ...
1 year, 7 months ago (2013-08-01 18:02:29 UTC) #3
John Messerly
also, this LGTM :)
1 year, 7 months ago (2013-08-01 18:02:47 UTC) #4
Siggi Cherem (dart-lang)
1 year, 7 months ago (2013-08-01 18:40:05 UTC) #5
Message was sent while issue was closed.
On 2013/08/01 18:02:29, John Messerly wrote:
> Crazy idea here (actually, 2 crazy ideas):
>   * Could we switch this proxy to use noSuchMethod, so it always works? The
code
> size impact isn't huge, and I'm less worried about ~10% code size for web_ui
> since it's our legacy package. That would give us more stability.
>   * Alternative, maybe we could do something like this:
> 
> import 'package:custom_element/custom_element.dart';
> 
> class WebComponent extends CustomElement {
>   ... add the web_ui stuff like composeChildren here ...
> }
> 
> WDYT?

yeah - I was thinking about #2 too, but I like #1, we should try it =)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87e6a26