InstantExtended: record initial focus state for omnibox interactions.

chrome/common/metrics/proto/omnibox_event.proto

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Stores information about an omnibox interaction.
 
 syntax = "proto2";
 
 option optimize_for = LITE_RUNTIME;
 
@@ skipping 51 matching lines @@
   enum PageClassification {
     INVALID_SPEC = 0;   // invalid URI; shouldn't happen
     NEW_TAB_PAGE = 1;   // chrome://newtab/
     // Note that chrome://newtab/ doesn't have to be the built-in
     // version; it could be replaced by an extension.
     BLANK = 2;          // about:blank
     HOMEPAGE = 3;       // user switched settings to "open this page" mode.
     // Note that if the homepage is set to the new tab page or about blank,
     // then we'll classify the web page into those categories, not HOMEPAGE.
     OTHER = 4;          // everything not included somewhere else on this list
-    INSTANT_NEW_TAB_PAGE = 5;  // new tab page rendered by Instant
+    OBSOLETE_INSTANT_NEW_TAB_PAGE = 5;  // new tab page rendered by Instant
     // The user is on a search result page that's doing search term
     // replacement, meaning the search terms should've appeared in the omnibox
     // before the user started editing it, not the URL of the page.
     SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT = 6;
+    // The new tab page in which this omnibox interaction first started
+    // with the user having focus in the omnibox.
+    INSTANT_NEW_TAB_PAGE_WITH_OMNIBOX_AS_STARTING_FOCUS = 7;
+    // The new tab page in which this omnibox interaction first started
+    // with the user having focus in the fakebox.
+    INSTANT_NEW_TAB_PAGE_WITH_FAKEBOX_AS_STARTING_FOCUS = 8;

[Ilya Sherman, 2013/08/02 21:47:32]

Please get the changes to the protocol buffer approved and landed in google3
prior to landing this CL.

[Mark P, 2013/08/02 21:53:24]

samarth: I'll do this for you.

[Mark P, 2013/08/03 00:19:03]

This is done.
https://cr/50306267

As part of this review, the logs team suggested replacing the above line 72
    OBSOLETE_INSTANT_NEW_TAB_PAGE = 5;  // new tab page rendered by Instant
with
    // The instant new tab page enum value was deprecated on August 2, 2013.
    OBSOLETE_INSTANT_NEW_TAB_PAGE = 5;

[samarth, 2013/08/06 16:29:25]

Done.

   }
   optional PageClassification current_page_classification = 10;
 
   // What kind of input the user provided.
   enum InputType {
     INVALID = 0;        // Empty input (should not reach here)
     UNKNOWN = 1;        // Valid input whose type cannot be determined
     REQUESTED_URL = 2;  // DEPRECATED. Input autodetected as UNKNOWN, which the
                         // user wants to treat as an URL by specifying a
                         // desired_tld
@@ skipping 91 matching lines @@
     // See AutocompleteController::ResetSession() for more details on the
     // definition of a session.
     // See chrome/browser/autocomplete/search_provider.cc for a specific usage
     // example.
     repeated fixed32 field_trial_triggered_in_session = 4;
   }
   // A list of diagnostic information about each provider.  Providers
   // will appear at most once in this list.
   repeated ProviderInfo provider_info = 12;
 }