InstantExtended: record initial focus state for omnibox interactions.

chrome/browser/autocomplete/autocomplete_input.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_INPUT_H_
 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_INPUT_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 40 matching lines @@
   enum PageClassification {
     INVALID_SPEC = 0,   // invalid URI; shouldn't happen
     NEW_TAB_PAGE = 1,   // chrome://newtab/
     // Note that chrome://newtab/ doesn't have to be the built-in
     // version; it could be replaced by an extension.
     BLANK = 2,          // about:blank
     HOMEPAGE = 3,       // user switched settings to "open this page" mode.
     // Note that if the homepage is set to the new tab page or about blank,
     // then we'll classify the web page into those categories, not HOMEPAGE.
     OTHER = 4,          // everything not included somewhere else on this list
-    INSTANT_NEW_TAB_PAGE = 5,  // new tab page rendered by Instant
+    OBSOLETE_INSTANT_NEW_TAB_PAGE = 5,  // new tab page rendered by Instant
     // The user is on a search result page that's doing search term
     // replacement, meaning the search terms should've appeared in the omnibox
     // before the user started editing it, not the URL of the page.
-    SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT = 6
+    SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT = 6,
+    // The new tab page in which this omnibox interaction first started
+    // with the user having focus in the omnibox.
+    INSTANT_NEW_TAB_PAGE_WITH_OMNIBOX_AS_STARTING_FOCUS = 7,

[Peter Kasting, 2013/08/02 17:59:38]

It's inappropriate to add this data here.  This enum is explicitly about "the
type of page currently displayed".  This split that you've added does not
distinguish between page types, instead it adds in another piece of orthogonal
data.  One could easily imagine adding such a split to all the other types, and
then having a third piece of data that we want to include and doubling all the
states again, etc.

Capture the data you need by looking at an additional piece of info somewhere,
do not include it in the PageClassification.

[Mark P, 2013/08/02 18:10:39]

I explicitly asked him to include it in PageClassification.  I think you're
right that now the name of and comment by the enum is misleading.  Perhaps
OmniboxContext or OmniboxEntryPoint might be better.

+    // The new tab page in which this omnibox interaction first started
+    // with the user having focus in the fakebox.
+    INSTANT_NEW_TAB_PAGE_WITH_FAKEBOX_AS_STARTING_FOCUS = 8,
   };
 
   AutocompleteInput();
   // |text| and |cursor_position| represent the input query and location of
   // the cursor with the query respectively.  |cursor_position| may be set to
   // string16::npos if the input |text| doesn't come directly from the user's
   // typing.
   //
   // |desired_tld| is the user's desired TLD, if one is not already present in
   // the text to autocomplete.  When this is non-empty, it also implies that
@@ skipping 146 matching lines @@
   url_parse::Parsed parts_;
   string16 scheme_;
   GURL canonicalized_url_;
   bool prevent_inline_autocomplete_;
   bool prefer_keyword_;
   bool allow_exact_keyword_match_;
   MatchesRequested matches_requested_;
 };
 
 #endif  // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_INPUT_H_