Fix for issue 12136 (do not try to copy type arguments if the base class

runtime/vm/debugger_api_impl.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_debugger_api.h"
 
 #include "vm/class_finalizer.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_state.h"
 #include "vm/debugger.h"
@@ skipping 505 matching lines @@
   UNWRAP_AND_CHECK_PARAM(Class, cls, cls_in);
   return Api::NewHandle(isolate, cls.SuperClass());
 }
 
 
 DART_EXPORT Dart_Handle Dart_GetSupertype(Dart_Handle type_in) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
 
   UNWRAP_AND_CHECK_PARAM(Type, type, type_in);
+  if (!type.IsFinalized()) {
+    return Api::NewError("%s: type in 'type_in' is not a finalized type",
+                         CURRENT_FUNC);
+  }

[regis, 2013/07/31 23:11:59]

You also need to check that type_in is instantiated, otherwise this
Dart_GetSupertype will return a nonsensical type.

[siva, 2013/07/31 23:24:05]

Done.

   const Class& cls= Class::Handle(type.type_class());
-  intptr_t num_expected_type_arguments = cls.NumTypeParameters();
-  if (num_expected_type_arguments == 0) {
+  if (cls.NumTypeParameters() == 0) {
     // The super type has no type parameters or it is already instantiated
     // just return it.
     const AbstractType& type = AbstractType::Handle(cls.super_type());
     if (type.IsNull()) {
       return Dart_Null();
     }
     return Api::NewHandle(isolate, type.Canonicalize());
   }
   // Set up the type arguments array for the super class type.
   const Class& super_cls = Class::Handle(cls.SuperClass());
-  num_expected_type_arguments = super_cls.NumTypeParameters();
+  intptr_t num_expected_type_arguments = super_cls.NumTypeArguments();
+  TypeArguments& super_type_args_array = TypeArguments::Handle();
   const AbstractTypeArguments& type_args_array =
       AbstractTypeArguments::Handle(type.arguments());
-  const TypeArguments& super_type_args_array =
-      TypeArguments::Handle(TypeArguments::New(num_expected_type_arguments));
-  AbstractType& type_arg = AbstractType::Handle();
-  intptr_t index_offset =
-      super_cls.NumTypeArguments() - num_expected_type_arguments;
-  for (intptr_t i = 0; i < num_expected_type_arguments; i++) {
-    type_arg ^= type_args_array.TypeAt(i + index_offset);
-    super_type_args_array.SetTypeAt(i, type_arg);
+  if (!type_args_array.IsNull() && (num_expected_type_arguments > 0)) {
+    super_type_args_array = TypeArguments::New(num_expected_type_arguments);
+    AbstractType& type_arg = AbstractType::Handle();
+    for (intptr_t i = 0; i < num_expected_type_arguments; i++) {
+      type_arg ^= type_args_array.TypeAt(i);
+      super_type_args_array.SetTypeAt(i, type_arg);
+    }
   }
 
   // Construct the super type object, canonicalize it and return.
   Type& instantiated_type = Type::Handle(
       Type::New(super_cls, super_type_args_array, Scanner::kDummyTokenIndex));
   ASSERT(!instantiated_type.IsNull());
-  instantiated_type ^= ClassFinalizer::FinalizeType(
-      super_cls, instantiated_type, ClassFinalizer::kCanonicalize);
-  return Api::NewHandle(isolate, instantiated_type.raw());
+  instantiated_type.SetIsFinalized();
+  return Api::NewHandle(isolate, instantiated_type.Canonicalize());
 }
 
 
 DART_EXPORT Dart_Handle Dart_GetClassInfo(
                             intptr_t cls_id,
                             Dart_Handle* class_name,
                             intptr_t* library_id,
                             intptr_t* super_class_id,
                             Dart_Handle* static_fields) {
   Isolate* isolate = Isolate::Current();
@@ skipping 258 matching lines @@
 
 
 DART_EXPORT char* Dart_GetVmStatus(const char* request) {
   if (strncmp(request, "/isolate/", 9) == 0) {
     return Isolate::GetStatus(request);
   }
   return NULL;
 }
 
 }  // namespace dart