Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 20571004: Helper classes to scope undo action. (Closed)

Created:
7 years, 4 months ago by Tom Cassiotis
Modified:
7 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Helper classes to scope undo action. Added 2 helper classes that allow scoping of the suspension of undo tracking and grouping actions for undo. BUG=126092 R=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214459

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -0 lines) Patch
A chrome/browser/undo/undo_manager_utils.h View 1 chunk +41 lines, -0 lines 0 comments Download
A chrome/browser/undo/undo_manager_utils.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Tom Cassiotis
sky@ please take a look. I took your cue to reduce the size of the ...
7 years, 4 months ago (2013-07-26 18:48:27 UTC) #1
sky
thanks, LGTM
7 years, 4 months ago (2013-07-26 19:26:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tom.cassiotis@gmail.com/20571004/1
7 years, 4 months ago (2013-07-26 20:54:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tom.cassiotis@gmail.com/20571004/1
7 years, 4 months ago (2013-07-26 21:44:08 UTC) #4
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=63844
7 years, 4 months ago (2013-07-27 23:51:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tom.cassiotis@gmail.com/20571004/1
7 years, 4 months ago (2013-07-29 15:45:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tom.cassiotis@gmail.com/20571004/1
7 years, 4 months ago (2013-07-30 03:17:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tom.cassiotis@gmail.com/20571004/1
7 years, 4 months ago (2013-07-30 14:41:42 UTC) #8
commit-bot: I haz the power
7 years, 4 months ago (2013-07-30 23:02:08 UTC) #9
Message was sent while issue was closed.
Change committed as 214459

Powered by Google App Engine
This is Rietveld 408576698