third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.h - Issue 2056053003: Change MediaKeys.setServerCertificate() to return Promise<boolean>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.h

Issue 2056053003: Change MediaKeys.setServerCertificate() to return Promise<boolean> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: resolve false Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-syntax.html ('K') | « third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-syntax.html ('k') | third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp » ('j') | third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.h

diff --git a/third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.h b/third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.h

index 62d995d5fa762cefd9abfb8c4edff27f8d64bc81..1e7bec3f4cc57d80d568a556b1ffe76cdfbf2056 100644

--- a/third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.h

+++ b/third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.h

@@ -26,7 +26,7 @@ public:

void complete() override;

void completeWithContentDecryptionModule(WebContentDecryptionModule*) override;

void completeWithSession(WebContentDecryptionModuleResult::SessionStatus) override;

- void completeWithError(WebContentDecryptionModuleException, unsigned long systemCode, const WebString&) final;

+ void completeWithError(WebContentDecryptionModuleException, unsigned long systemCode, const WebString&) override;

// It is only valid to call this before completion.

ScriptPromise promise();