(spatnav) Space&enter should be entered to box instead of simulating click on it.

(spatnav) Space&enter should be entered to box instead of simulating click on it.

This fixes the regression after https://codereview.chromium.org/16959002/
which makes it impossible to enter spaces into edit boxes
in spatial navigation mode.

Bug is reproducible only with spatial navigation enabled.
So is this fix.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155993

[Krzysztof Olczyk, 2013-07-26 08:33:15]

A quick bug fix to spatial navigation.

[esprehn, 2013-07-26 08:49:29]

On 2013/07/26 08:33:15, Krzysztof Olczyk wrote:
> A quick bug fix to spatial navigation.

This needs a test. :)

[Krzysztof Olczyk, 2013-07-26 10:38:18]

Tests added. :)

[esprehn, 2013-07-26 11:00:02]

I don't understand how this test works, you changed a bunch of tests but didn't
change any expectations? Also how does the test where you just added a bunch of
elements work? There's no test code in there.

https://codereview.chromium.org/20560005/diff/8001/LayoutTests/fast/spatial-n...
File LayoutTests/fast/spatial-navigation/snav-input.html (right):

https://codereview.chromium.org/20560005/diff/8001/LayoutTests/fast/spatial-n...
LayoutTests/fast/spatial-navigation/snav-input.html:74: for (var i in text)
I don't know if it's standard to iterate over a string like this.

https://codereview.chromium.org/20560005/diff/8001/ManualTests/spatial-naviga...
File ManualTests/spatial-navigation/spatial-navigation-test-cases.html (right):

https://codereview.chromium.org/20560005/diff/8001/ManualTests/spatial-naviga...
ManualTests/spatial-navigation/spatial-navigation-test-cases.html:159: Nulla
auctor porta sapien, vitae elementum libero rhoncus ac. Sed pretium vel neque a
interdum. Duis id tristique lacus. Nulla vel lobortis libero. Morbi nisi quam,
aliquet vel leo id, hendrerit imperdiet sem. Mauris interdum, odio non interdum
tempus, turpis tellus ornare ipsum, quis cursus risus tellus quis nisl.
Suspendisse dictum elit ut lectus auctor tincidunt. Aenean at egestas mi. Morbi
porttitor dictum ipsum blandit tincidunt. Sed eu justo libero. Proin interdum
tempor gravida.
Is there script or something in this test that uses the content editable area?

https://codereview.chromium.org/20560005/diff/8001/Source/core/html/HTMLEleme...
File Source/core/html/HTMLElement.cpp (right):

https://codereview.chromium.org/20560005/diff/8001/Source/core/html/HTMLEleme...
Source/core/html/HTMLElement.cpp:1081: // even in spatial navigation mode
instead of handling it as "click" action.
as a "click"

[Krzysztof Olczyk, 2013-07-26 11:10:46]

Oops. Sorry, *-expected.txt files did not get uploaded.

https://codereview.chromium.org/20560005/diff/8001/LayoutTests/fast/spatial-n...
File LayoutTests/fast/spatial-navigation/snav-input.html (right):

https://codereview.chromium.org/20560005/diff/8001/LayoutTests/fast/spatial-n...
LayoutTests/fast/spatial-navigation/snav-input.html:74: for (var i in text)
On 2013/07/26 11:00:02, esprehn wrote:
> I don't know if it's standard to iterate over a string like this.

Done.

https://codereview.chromium.org/20560005/diff/8001/ManualTests/spatial-naviga...
File ManualTests/spatial-navigation/spatial-navigation-test-cases.html (right):

https://codereview.chromium.org/20560005/diff/8001/ManualTests/spatial-naviga...
ManualTests/spatial-navigation/spatial-navigation-test-cases.html:159: Nulla
auctor porta sapien, vitae elementum libero rhoncus ac. Sed pretium vel neque a
interdum. Duis id tristique lacus. Nulla vel lobortis libero. Morbi nisi quam,
aliquet vel leo id, hendrerit imperdiet sem. Mauris interdum, odio non interdum
tempus, turpis tellus ornare ipsum, quis cursus risus tellus quis nisl.
Suspendisse dictum elit ut lectus auctor tincidunt. Aenean at egestas mi. Morbi
porttitor dictum ipsum blandit tincidunt. Sed eu justo libero. Proin interdum
tempor gravida.
On 2013/07/26 11:00:02, esprehn wrote:
> Is there script or something in this test that uses the content editable area?

No, but it is a manual test.

https://codereview.chromium.org/20560005/diff/8001/Source/core/html/HTMLEleme...
File Source/core/html/HTMLElement.cpp (right):

https://codereview.chromium.org/20560005/diff/8001/Source/core/html/HTMLEleme...
Source/core/html/HTMLElement.cpp:1081: // even in spatial navigation mode
instead of handling it as "click" action.
On 2013/07/26 11:00:02, esprehn wrote:
> as a "click"

Done.

[Krzysztof Olczyk, 2013-07-31 12:39:16]

@esprehn, is it OK now?

[esprehn, 2013-08-07 05:22:40]

LGTM

[commit-bot: I haz the power, 2013-08-13 06:59:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kolczyk@opera.com/20560005/15001

[commit-bot: I haz the power, 2013-08-13 08:48:35]

Change committed as 155993