Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: courgette/disassembler_elf_32_x86_unittest.cc

Issue 2055343002: Courgette: Add static method QuickDetect() to optimize program detection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « courgette/disassembler_elf_32_x86.cc ('k') | courgette/disassembler_win32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: courgette/disassembler_elf_32_x86_unittest.cc
diff --git a/courgette/disassembler_elf_32_x86_unittest.cc b/courgette/disassembler_elf_32_x86_unittest.cc
index af8a540f5ee737ff44188b4495325f1c63c84c75..29304219d78e7c59dc95bc14ca74abd6ca8c2986 100644
--- a/courgette/disassembler_elf_32_x86_unittest.cc
+++ b/courgette/disassembler_elf_32_x86_unittest.cc
@@ -24,9 +24,9 @@ namespace {
class TestDisassemblerElf32X86 : public DisassemblerElf32X86 {
public:
- TestDisassemblerElf32X86(const void* start, size_t length)
- : DisassemblerElf32X86(start, length) { }
- ~TestDisassemblerElf32X86() override { }
+ TestDisassemblerElf32X86(const uint8_t* start, size_t length)
+ : DisassemblerElf32X86(start, length) {}
+ ~TestDisassemblerElf32X86() override {}
void TestSectionHeaderFileOffsetOrder() {
std::vector<FileOffset> file_offsets;
@@ -70,7 +70,8 @@ void DisassemblerElf32X86Test::TestExe(const char* file_name,
std::string file1 = FileContents(file_name);
std::unique_ptr<TestDisassemblerElf32X86> disassembler(
- new TestDisassemblerElf32X86(file1.c_str(), file1.length()));
+ new TestDisassemblerElf32X86(
+ reinterpret_cast<const uint8_t*>(file1.c_str()), file1.length()));
bool can_parse_header = disassembler->ParseHeader();
EXPECT_TRUE(can_parse_header);
« no previous file with comments | « courgette/disassembler_elf_32_x86.cc ('k') | courgette/disassembler_win32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698