Courgette: Add static method QuickDetect() to optimize program detection.

courgette/disassembler_elf_32_x86_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "courgette/disassembler_elf_32_x86.h"
 
 #include <ctype.h>
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
 #include <memory>
 #include <set>
 #include <string>
 #include <vector>
 
 #include "courgette/assembly_program.h"
 #include "courgette/base_test_unittest.h"
 #include "courgette/image_utils.h"
 
 namespace courgette {
 
 namespace {
 
 class TestDisassemblerElf32X86 : public DisassemblerElf32X86 {
  public:
-  TestDisassemblerElf32X86(const void* start, size_t length)
-    : DisassemblerElf32X86(start, length) { }
+  TestDisassemblerElf32X86(const uint8_t* start, size_t length)
+      : DisassemblerElf32X86(start, length) {}
   ~TestDisassemblerElf32X86() override { }

[huangs, 2016/06/15 00:13:04]

May as well change "{ }" to "{}" in this line.

[etiennep, 2016/06/15 20:38:06]

Done.

 
   void TestSectionHeaderFileOffsetOrder() {
     std::vector<FileOffset> file_offsets;
     for (Elf32_Half section_id : section_header_file_offset_order_) {
       const Elf32_Shdr* section_header = SectionHeader(section_id);
       file_offsets.push_back(section_header->sh_offset);
     }
     EXPECT_EQ(static_cast<size_t>(SectionHeaderCount()), file_offsets.size());
     EXPECT_TRUE(std::is_sorted(file_offsets.begin(), file_offsets.end()));
   }
@@ skipping 23 matching lines @@
                size_t expected_abs_count,
                size_t expected_rel_count) const;
 };
 
 void DisassemblerElf32X86Test::TestExe(const char* file_name,
                                        size_t expected_abs_count,
                                        size_t expected_rel_count) const {
   std::string file1 = FileContents(file_name);
 
   std::unique_ptr<TestDisassemblerElf32X86> disassembler(
-      new TestDisassemblerElf32X86(file1.c_str(), file1.length()));
+      new TestDisassemblerElf32X86(
+          reinterpret_cast<const uint8_t*>(file1.c_str()), file1.length()));
 
   bool can_parse_header = disassembler->ParseHeader();
   EXPECT_TRUE(can_parse_header);
   EXPECT_TRUE(disassembler->ok());
 
   // The length of the disassembled value will be slightly smaller than the
   // real file, since trailing debug info is not included
   EXPECT_EQ(file1.length(), disassembler->length());
 
   const uint8_t* offset_p = disassembler->FileOffsetToPointer(0);
@@ skipping 44 matching lines @@
 }
 
 }  // namespace
 
 TEST_F(DisassemblerElf32X86Test, All) {
   TestExe("elf-32-1", 200, 3337);
   TestExe("elf-32-high-bss", 0, 4);
 }
 
 }  // namespace courgette