Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 20536003: [Downloads] Persist ETag and Last-Modified headers. (Closed)

Created:
7 years, 4 months ago by asanka
Modified:
7 years, 4 months ago
Reviewers:
benjhayden, jam, sky
CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, benjhayden+dwatch_chromium.org, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

[Downloads] Persist ETag and Last-Modified headers. These response headers are used for partial download resumption. If an interrupted download had a valid strong ETag header and the server supports byte range requests, then a subsequent downloads resumption attempt could fetch part of a resource instead of the entire resource. While the Last-Modified header is also used for validation currently, its use will be discontinued since a matching Last-Modifed value does not imply byte-wise equivalence. Without persisting these headers, partial downloads resumption will only work for downloads that are interrupted and resumed during the same browser session. BUG=7648 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216493

Patch Set 1 : #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : Merge with r216193 #

Patch Set 4 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+426 lines, -235 lines) Patch
M chrome/browser/download/download_browsertest.cc View 1 2 3 3 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/download/download_history.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/download/download_history_unittest.cc View 1 15 chunks +206 lines, -183 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/history/download_database.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/history/download_database.cc View 1 9 chunks +52 lines, -36 lines 0 comments Download
M chrome/browser/history/download_row.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/history/download_row.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/history/history_database.cc View 2 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/history/history_unittest.cc View 1 2 3 3 chunks +69 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/downloads_dom_handler_browsertest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A + chrome/test/data/History/history.27.sql View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/test/data/download-test1.lib.mock-http-headers View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/download/download_item_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/download/download_item_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/download/download_item_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/download/download_manager_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/download/download_manager_impl.cc View 4 chunks +8 lines, -0 lines 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M content/public/browser/download_manager.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/public/test/mock_download_manager.h View 3 chunks +6 lines, -0 lines 0 comments Download
M content/public/test/mock_download_manager.cc View 5 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
asanka
sky: chrome/browser/history jam: content/public benjhayden: everything else. What's the correct procedure for creating the history.27.sql ...
7 years, 4 months ago (2013-08-05 20:28:57 UTC) #1
jam
On 2013/08/05 20:28:57, asanka wrote: > sky: chrome/browser/history > jam: content/public lgtm > benjhayden: everything ...
7 years, 4 months ago (2013-08-05 23:07:53 UTC) #2
sky
LGTM
7 years, 4 months ago (2013-08-06 00:01:14 UTC) #3
benjhayden
On 2013/08/05 20:28:57, asanka wrote: > sky: chrome/browser/history > jam: content/public > benjhayden: everything else. ...
7 years, 4 months ago (2013-08-06 13:15:25 UTC) #4
benjhayden
https://codereview.chromium.org/20536003/diff/18001/chrome/test/data/History/history.27.sql File chrome/test/data/History/history.27.sql (right): https://codereview.chromium.org/20536003/diff/18001/chrome/test/data/History/history.27.sql#newcode10 chrome/test/data/History/history.27.sql:10: CREATE TABLE downloads (id INTEGER PRIMARY KEY,current_path LONGVARCHAR NOT ...
7 years, 4 months ago (2013-08-06 15:07:29 UTC) #5
benjhayden
Oh, wait, nevermind about 27.sql. You're migrating to 28. LGTM
7 years, 4 months ago (2013-08-06 15:08:22 UTC) #6
benjhayden
https://codereview.chromium.org/20536003/diff/18001/chrome/browser/history/history_unittest.cc File chrome/browser/history/history_unittest.cc (right): https://codereview.chromium.org/20536003/diff/18001/chrome/browser/history/history_unittest.cc#newcode604 chrome/browser/history/history_unittest.cc:604: ASSERT_LE(27, cur_version); 28?
7 years, 4 months ago (2013-08-06 15:09:12 UTC) #7
asanka
Thanks everyone! https://codereview.chromium.org/20536003/diff/18001/chrome/browser/history/history_unittest.cc File chrome/browser/history/history_unittest.cc (right): https://codereview.chromium.org/20536003/diff/18001/chrome/browser/history/history_unittest.cc#newcode604 chrome/browser/history/history_unittest.cc:604: ASSERT_LE(27, cur_version); On 2013/08/06 15:09:12, benjhayden_chromium wrote: ...
7 years, 4 months ago (2013-08-07 21:40:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/20536003/36001
7 years, 4 months ago (2013-08-08 19:54:57 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-08 20:39:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/20536003/36001
7 years, 4 months ago (2013-08-08 21:05:09 UTC) #11
commit-bot: I haz the power
7 years, 4 months ago (2013-08-08 23:53:25 UTC) #12
Message was sent while issue was closed.
Change committed as 216493

Powered by Google App Engine
This is Rietveld 408576698