Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2053003002:
media: Enable media_mojo_unittests on bots (Closed)
|
Created:
4 years, 6 months ago by xhwang Modified:
4 years, 6 months ago CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionmedia: Enable media_mojo_unittests on bots
Also fix some BUILD.gn files.
BUG=617204
Committed: https://crrev.com/72421f05b895615110d7fcc43b56e31942f34c54
Cr-Commit-Position: refs/heads/master@{#399947}
Patch Set 1 #
Total comments: 1
Patch Set 2 : rebase only #Patch Set 3 : rebase only #Patch Set 4 : fyi #Patch Set 5 : only enable on two bots #
Messages
Total messages: 40 (12 generated)
xhwang@chromium.org changed reviewers: + jam@chromium.org
PTAL https://chromiumcodereview.appspot.com/2053003002/diff/1/BUILD.gn File BUILD.gn (right): https://chromiumcodereview.appspot.com/2053003002/diff/1/BUILD.gn#newcode651 BUILD.gn:651: "//mojo", I wonder why these targets are win/linux only. Why can't they be built on Mac and Android? At least the media mojo ones are platform neutral. For now I am just following the model of media_mojo_shell_unittests.
rebase only
has this been running on fyi bots before? i.e. do we have data on its speed and flakiness?
Good questions. As you can see I am pretty new in how to get tests enabled :) So questions and help are more than welcome. On 2016/06/10 16:35:59, jam wrote: > has this been running on fyi bots before? I don't know. I suppose not since they are not specified anywhere? How do I enable them on fyi bots, and how do I monitor those bots? > i.e. do we have data on its speed and flakiness? These tests are just unittests (no playback of media etc) and should be pretty fast. Also they are pretty simple so they should not be flaky, otherwise we'll need to fix them.
On 2016/06/10 16:49:55, xhwang wrote: > Good questions. As you can see I am pretty new in how to get tests enabled :) So > questions and help are more than welcome. > > On 2016/06/10 16:35:59, jam wrote: > > has this been running on fyi bots before? > > I don't know. I suppose not since they are not specified anywhere? How do I > enable them on fyi bots, and how do I monitor those bots? instead of changing chromium.linux, you can change chromium.fyi. you might want to check with someone from infra if there's a good existing bot to run this temporarily on > > > i.e. do we have data on its speed and flakiness? > > These tests are just unittests (no playback of media etc) and should be pretty > fast. Also they are pretty simple so they should not be flaky, otherwise we'll > need to fix them. it would be good to verify this, especially the latter, before it goes on the CQ. sometimes flakiness is manifested as hangs, which could cause long test running times.
rebase only
xhwang@chromium.org changed reviewers: + agable@chromium.org
+agable from infra's perspective Updated, PTAL again.
BTW, how do I manually trigger a fyi bot?
I don't think you need them running on all these bots, just one.
I added to two bots just in case. PTAL again.
Description was changed from ========== media: Enable media_mojo_unittests on bots Also fix some BUILD.gn files. BUG=617204 ========== to ========== media: Enable media_mojo_unittests on bots Also fix some BUILD.gn files. BUG=617204 ==========
jam@chromium.org changed reviewers: + thakis@chromium.org
+Nico to see if he's fine with this (i.e. using FYI bots for testing new clang to also check that new test suite is stable before adding it to main waterfall & CQ). it seems like ideally we would have a "proving grounds" FYI bot.
This is fine with me if you monitor how the new test binary does on these two bots, under these two conditions: 1.) If they're be broken / flaky, either very quickly fix or revert the change to the json file while you fix (and then reland, repeat) 2.) If they work fine, add them to main waterfall bots quickly (say, after a few days of the tests being green).
On 2016/06/14 12:34:50, Nico (traveling...slow) wrote: > This is fine with me if you monitor how the new test binary does on these two > bots, under these two conditions: > 1.) If they're be broken / flaky, either very quickly fix or revert the change > to the json file while you fix (and then reland, repeat) > 2.) If they work fine, add them to main waterfall bots quickly (say, after a few > days of the tests being green). These sound reasonable to me. I can watch the bots today after it's landed, and add then to the main waterfall bots later this week or early next week if they look good. BTW, where do I see the fyi bots?
the clang tot bots are at https://build.chromium.org/p/chromium.fyi/console?category=clang%20tot (they're currently pretty red due to clang upstream troubles, but they should all cycle green now, assuming nothing else broke since we fixed the last thing) On Tue, Jun 14, 2016 at 2:41 PM, <xhwang@chromium.org> wrote: > On 2016/06/14 12:34:50, Nico (traveling...slow) wrote: > > This is fine with me if you monitor how the new test binary does on > these two > > bots, under these two conditions: > > 1.) If they're be broken / flaky, either very quickly fix or revert the > change > > to the json file while you fix (and then reland, repeat) > > 2.) If they work fine, add them to main waterfall bots quickly (say, > after a > few > > days of the tests being green). > > These sound reasonable to me. I can watch the bots today after it's > landed, and > add then to the main waterfall bots later this week or early next week if > they > look good. > > BTW, where do I see the fyi bots? > > https://chromiumcodereview.appspot.com/2053003002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Thanks. jam: Would you like to approve this change?
The CQ bit was checked by xhwang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053003002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by xhwang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053003002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
jam@google.com changed reviewers: + jam@google.com
lgtm
The CQ bit was checked by xhwang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053003002/80001
lgtm
Message was sent while issue was closed.
Description was changed from ========== media: Enable media_mojo_unittests on bots Also fix some BUILD.gn files. BUG=617204 ========== to ========== media: Enable media_mojo_unittests on bots Also fix some BUILD.gn files. BUG=617204 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== media: Enable media_mojo_unittests on bots Also fix some BUILD.gn files. BUG=617204 ========== to ========== media: Enable media_mojo_unittests on bots Also fix some BUILD.gn files. BUG=617204 Committed: https://crrev.com/72421f05b895615110d7fcc43b56e31942f34c54 Cr-Commit-Position: refs/heads/master@{#399947} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/72421f05b895615110d7fcc43b56e31942f34c54 Cr-Commit-Position: refs/heads/master@{#399947}
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2071623002/ by hcarmona@chromium.org. The reason for reverting is: Fails to compile on https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28d....
Message was sent while issue was closed.
for relanding, one more comment: looks like this added the test to the test list of a gyp build while the target is gn-only (https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/8402)
Message was sent while issue was closed.
On 2016/06/15 20:57:47, Nico (traveling...slow) wrote: > for relanding, one more comment: looks like this added the test to the test list > of a gyp build while the target is gn-only > (https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/8402) Thanks for catching that. It seems all fyi windows bots are on GYP. I can just drop the change on ClangToTWin, but then I'll lose Windows coverage :( |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
